Comment type entity should declare dependency on extension of the target entity type

+++ b/core/modules/comment/tests/src/Functional/CommentTypeTest.php
@@ -192,6 +192,22 @@ public function testCommentTypeDeletion() {
+    $this->assertSession()->pageTextNotContains('node_dependent');

Should we add an assert here that the status code is a 200?

Needs a reroll for 10.1.x and the upgrade path tests

Since this is no longer about Node, tests should also be re-worked to use the generic EntityTest type.

Updated summary to reduce pointing to Node

Re-rolled patch for 11.x. Keeping this in "Needs work" to update the test as per #62.

Addressed #61 "Should we add an assert here that the status code is a 200?".
Patch created, Keeping this in "Needs work" as we have failed test cases.

Fixing Test cases, Please have a look. Keeps in "Needs Work" having some fail tests.

Test passed, Moving to needs review. Please have a look.

Looks good, though I'm curious about the reason for these guards:

1. +++ b/core/modules/comment/src/Entity/CommentType.php
   @@ -103,4 +103,22 @@ public function getTargetEntityTypeId() {
   +    if ($type) {
   

   What does it mean if $type is empty?

2. +++ b/core/modules/comment/src/Entity/CommentType.php
   @@ -103,4 +103,22 @@ public function getTargetEntityTypeId() {
   +      if (\Drupal::moduleHandler()->moduleExists($provider)) {
   

   What does it mean if the provider module does not exist?

Seems upgrade path tests are still needed.