- ๐บ๐ธUnited States MegaKeegMan
Can confirm that this patch does not apply, but is absolutely still needed.
- Status changed to Needs review
over 2 years ago 12:51pm 16 March 2023 - ๐ฎ๐ณIndia gauravvvv Delhi, India
I have attached a patch for same, please review
- Status changed to Needs work
over 2 years ago 4:19pm 16 March 2023 - ๐บ๐ธUnited States smustgrave
Next step would be to get a test case to show the issue.
- ๐บ๐ธUnited States MegaKeegMan
At the very least I can say that patch #24 does apply and does fix the issue. Tested on Drupal 9.5.4
- Merge request !13162Ensure adding attributes to views-view-list.html.twig works โ (Open) created by mlncn
- ๐บ๐ธUnited States mlncn Minneapolis, MN, USA
Merge request !13162 is a straightforward rerollโ exactly what is in daniel korte's patch initial patch in #2 ๐ Adding attributes to views-view-list.html.twig doesn't work if Views List class Style option is empty Needs work got into core through changes made out of this issue (without tests?!), so technically the problem stated in the title of this issue is now fixed in Drupal core. My re-roll of a merge request therefore only preserves jwilson's proposal in #12 ๐ Adding attributes to views-view-list.html.twig doesn't work if Views List class Style option is empty Needs work , implemented in gauravvvv's patch in #24 ๐ Adding attributes to views-view-list.html.twig doesn't work if Views List class Style option is empty Needs work , to not blow away attributes that were added by a possibly earlier preprocess.
I agree this is how it should work, but am not up for a test, let alone making this consistent everywhere, and i know there are rumblings about somehow getting rid of
hook_preprocess
entirely, however that would work, so i leave this humble re-roll and update as my offering. - ๐บ๐ธUnited States smustgrave
Thanks for re-rolling!
Tagging for issue summary as the standard template appears to be missing.
Based on the title seems like something that tests should cover so am leaving that tag.
Thanks!