FileSystemInterface::copy documentation is inaccurate

patch #33 applied cleanly on D9.5.x.

Change in #33 seems fine too me.

I don't think this is right.

https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21File%21Fi... - this throws an exception if $source and $destination are the same.

Exception is also documented here: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21File%21Fi...

Also the issue summary is still referencing the procedural functions that were removed a long time ago.

Updated issue summary and created an MR.

Added example and updated $fileExists parameters.

thanks for the fix

Oh, nice to see the quick response, thanks.

Left a comment on the MR that needs a response.

Thanks @quietone. Updated.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Would agree with removing $file_system->prepareDirectory($directory, FileSystemInterface::CREATE_DIRECTORY); mainly because the sentence below the example mentions copying but nothing about needing to prepare the folder, which to my knowledge isn't always needed

Removed $file_system->prepareDirectory($directory, FileSystemInterface::CREATE_DIRECTORY); from example.

Docs are updated as required.
RTBC.

I removed one blank line from the changes so this meets coding standards. And updated credit.

The changes are an improvement so if there is anything more let's put that in a followup. Leaving at RTBC.

nod_ → closed merge request !8587

Thanks for sorting out the credits.

Committed d135a79 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.