- 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.
- Assigned to nitin_lama
- 🇮🇳India nitin_lama India
There were more issue left. Fixed most of them. Providing the updated patch.
- 🇮🇳India nitin_lama India
Kindly review the IS and inform me whether the remaining issues require resolution or not. Thanks.
- Issue was unassigned.
- Status changed to Needs review
12 months ago 11:54am 27 December 2023 - 🇮🇳India dev16.addweb
I have fixed every mentioned error in this patch; kindly review.
------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 9 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 10 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 11 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 12 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ------------------------------------------------------------------------------------------------------------------------------------------------------------------- - Status changed to Needs work
7 months ago 6:34am 6 June 2024 - 🇵🇭Philippines cleavinjosh
Hi @silvi.addweb,
I have applied patch#33 and it was applied smoothly.
However, I still encounter some issues after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml.➜ classy_paragraphs git:(8.x-1.0-rc3) ✗ curl https://www.drupal.org/files/issues/2024-05-30/classy_paragraphs-2835021-33.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 12768 100 12768 0 0 15725 0 --:--:-- --:--:-- --:--:-- 15724 patching file classy_paragraphs.links.action.yml patching file classy_paragraphs.links.menu.yml patching file classy_paragraphs.module patching file classy_paragraphs.routing.yml patching file src/ClassyParagraphsAccessControlHandler.php patching file src/ClassyParagraphsStyleInterface.php patching file src/ClassyParagraphsStyleListBuilder.php patching file src/Entity/ClassyParagraphsStyle.php patching file src/Form/ClassyParagraphsStyleDeleteForm.php patching file src/Form/ClassyParagraphsStyleForm.php patching file src/Plugin/EntityReferenceSelection/ClassyParagraphsSelection.php patching file src/Tests/ClassyParagraphsTest.php patching file tests/modules/classy_paragraphs_test/classy_paragraphs_test.info.yml ➜ classy_paragraphs git:(8.x-1.0-rc3) ✗ .. ➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml classy_paragraphs FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/classy_paragraphs/tests/modules/classy_paragraphs_test/classy_paragraphs_test.info.yml ----------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------------------------- 12 | ERROR | [x] Expected 1 newline at end of file; 2 found ----------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/classy_paragraphs/README.md ------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 19 WARNINGS AFFECTING 19 LINES ------------------------------------------------------------------------------------------------ 56 | WARNING | Line exceeds 80 characters; contains 146 characters 57 | WARNING | Line exceeds 80 characters; contains 228 characters 59 | WARNING | Line exceeds 80 characters; contains 116 characters 60 | WARNING | Line exceeds 80 characters; contains 104 characters 62 | WARNING | Line exceeds 80 characters; contains 130 characters 63 | WARNING | Line exceeds 80 characters; contains 111 characters 68 | WARNING | Line exceeds 80 characters; contains 96 characters 71 | WARNING | Line exceeds 80 characters; contains 154 characters 74 | WARNING | Line exceeds 80 characters; contains 97 characters 75 | WARNING | Line exceeds 80 characters; contains 153 characters 78 | WARNING | Line exceeds 80 characters; contains 92 characters 80 | WARNING | Line exceeds 80 characters; contains 198 characters 84 | WARNING | Line exceeds 80 characters; contains 88 characters 86 | WARNING | Line exceeds 80 characters; contains 104 characters 87 | WARNING | Line exceeds 80 characters; contains 108 characters 89 | WARNING | Line exceeds 80 characters; contains 331 characters 90 | WARNING | Line exceeds 80 characters; contains 400 characters 97 | WARNING | Line exceeds 80 characters; contains 95 characters 117 | WARNING | Line exceeds 80 characters; contains 125 characters ------------------------------------------------------------------------------------------------ Time: 239ms; Memory: 10MB ➜ contrib git:(main) ✗Thank you.
- Status changed to Needs review
7 months ago 8:01am 6 June 2024 - Status changed to Needs work
7 months ago 12:05pm 6 June 2024 - 🇵🇭Philippines cleavinjosh
Hi @apaderno,
I applied MR!3, it was applied smoothly.
However, I still encounter some issues after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml.➜ classy_paragraphs git:(8.x-1.0-rc3) curl https://git.drupalcode.org/project/classy_paragraphs/-/merge_requests/3.diff | git apply -v % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 12633 0 12633 0 0 35815 0 --:--:-- --:--:-- --:--:-- 35889 Checking patch .gitlab-ci.yml... Checking patch classy_paragraphs.module... Checking patch src/ClassyParagraphsAccessControlHandler.php... Checking patch src/ClassyParagraphsStyleInterface.php... Checking patch src/ClassyParagraphsStyleListBuilder.php... Checking patch src/Entity/ClassyParagraphsStyle.php... Checking patch src/Form/ClassyParagraphsStyleDeleteForm.php... Checking patch src/Form/ClassyParagraphsStyleForm.php... Checking patch src/Plugin/EntityReferenceSelection/ClassyParagraphsSelection.php... Checking patch src/Tests/ClassyParagraphsTest.php... Applied patch .gitlab-ci.yml cleanly. Applied patch classy_paragraphs.module cleanly. Applied patch src/ClassyParagraphsAccessControlHandler.php cleanly. Applied patch src/ClassyParagraphsStyleInterface.php cleanly. Applied patch src/ClassyParagraphsStyleListBuilder.php cleanly. Applied patch src/Entity/ClassyParagraphsStyle.php cleanly. Applied patch src/Form/ClassyParagraphsStyleDeleteForm.php cleanly. Applied patch src/Form/ClassyParagraphsStyleForm.php cleanly. Applied patch src/Plugin/EntityReferenceSelection/ClassyParagraphsSelection.php cleanly. Applied patch src/Tests/ClassyParagraphsTest.php cleanly. ➜ classy_paragraphs git:(8.x-1.0-rc3) ✗ .. ➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml classy_paragraphs FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/classy_paragraphs/classy_paragraphs.links.action.yml ------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------- 5 | ERROR | [x] Expected 1 newline at end of file; 2 found ------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/classy_paragraphs/tests/modules/classy_paragraphs_test/classy_paragraphs_test.info.yml ----------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES ----------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 9 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 10 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 11 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 12 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ----------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/classy_paragraphs/README.md ------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 19 WARNINGS AFFECTING 19 LINES ------------------------------------------------------------------------------------------------ 56 | WARNING | Line exceeds 80 characters; contains 146 characters 57 | WARNING | Line exceeds 80 characters; contains 228 characters 59 | WARNING | Line exceeds 80 characters; contains 116 characters 60 | WARNING | Line exceeds 80 characters; contains 104 characters 62 | WARNING | Line exceeds 80 characters; contains 130 characters 63 | WARNING | Line exceeds 80 characters; contains 111 characters 68 | WARNING | Line exceeds 80 characters; contains 96 characters 71 | WARNING | Line exceeds 80 characters; contains 154 characters 74 | WARNING | Line exceeds 80 characters; contains 97 characters 75 | WARNING | Line exceeds 80 characters; contains 153 characters 78 | WARNING | Line exceeds 80 characters; contains 92 characters 80 | WARNING | Line exceeds 80 characters; contains 198 characters 84 | WARNING | Line exceeds 80 characters; contains 88 characters 86 | WARNING | Line exceeds 80 characters; contains 104 characters 87 | WARNING | Line exceeds 80 characters; contains 108 characters 89 | WARNING | Line exceeds 80 characters; contains 331 characters 90 | WARNING | Line exceeds 80 characters; contains 400 characters 97 | WARNING | Line exceeds 80 characters; contains 95 characters 117 | WARNING | Line exceeds 80 characters; contains 125 characters ------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/classy_paragraphs/classy_paragraphs.routing.yml -------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 41 | ERROR | [x] Expected 1 newline at end of file; 2 found -------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/classy_paragraphs/classy_paragraphs.module --------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------- 55 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found --------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/classy_paragraphs/classy_paragraphs.links.menu.yml ----------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Expected 1 newline at end of file; 2 found ----------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/classy_paragraphs/src/Tests/ClassyParagraphsTest.php ------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\node\Entity\Node. 31 | ERROR | [x] Closing parenthesis of array declaration must be on a new line ------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/classy_paragraphs/src/Plugin/EntityReferenceSelection/ClassyParagraphsSelection.php -------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------- 69 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 77 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 87 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 87 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead -------------------------------------------------------------------------------------------------------------------------------------------------------- Time: 206ms; Memory: 10MB ➜ contrib git:(main) ✗Thank you.
- Status changed to Needs review
7 months ago 1:28pm 6 June 2024 - Status changed to Needs work
7 months ago 7:42am 7 June 2024 - 🇵🇭Philippines cleavinjosh
Hi @apaderno,
I applied MR!3 and it was applied smoothly.
However, I still encountered some issues after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml.➜ classy_paragraphs git:(8.x-1.0-rc3) curl https://git.drupalcode.org/project/classy_paragraphs/-/merge_requests/3.diff | git apply -v % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 13029 0 13029 0 0 36767 0 --:--:-- --:--:-- --:--:-- 36701 Checking patch .gitlab-ci.yml... Checking patch classy_paragraphs.module... Checking patch src/ClassyParagraphsAccessControlHandler.php... Checking patch src/ClassyParagraphsStyleInterface.php... Checking patch src/ClassyParagraphsStyleListBuilder.php... Checking patch src/Entity/ClassyParagraphsStyle.php... Checking patch src/Form/ClassyParagraphsStyleDeleteForm.php... Checking patch src/Form/ClassyParagraphsStyleForm.php... Checking patch src/Plugin/EntityReferenceSelection/ClassyParagraphsSelection.php... Checking patch src/Tests/ClassyParagraphsTest.php... Applied patch .gitlab-ci.yml cleanly. Applied patch classy_paragraphs.module cleanly. Applied patch src/ClassyParagraphsAccessControlHandler.php cleanly. Applied patch src/ClassyParagraphsStyleInterface.php cleanly. Applied patch src/ClassyParagraphsStyleListBuilder.php cleanly. Applied patch src/Entity/ClassyParagraphsStyle.php cleanly. Applied patch src/Form/ClassyParagraphsStyleDeleteForm.php cleanly. Applied patch src/Form/ClassyParagraphsStyleForm.php cleanly. Applied patch src/Plugin/EntityReferenceSelection/ClassyParagraphsSelection.php cleanly. Applied patch src/Tests/ClassyParagraphsTest.php cleanly. ➜ classy_paragraphs git:(8.x-1.0-rc3) ✗ .. ➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml classy_paragraphs FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/classy_paragraphs/classy_paragraphs.links.action.yml ------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------- 5 | ERROR | [x] Expected 1 newline at end of file; 2 found ------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/classy_paragraphs/tests/modules/classy_paragraphs_test/classy_paragraphs_test.info.yml ----------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES ----------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 9 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 10 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 11 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" 12 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ----------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/classy_paragraphs/README.md ------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 19 WARNINGS AFFECTING 19 LINES ------------------------------------------------------------------------------------------------ 56 | WARNING | Line exceeds 80 characters; contains 146 characters 57 | WARNING | Line exceeds 80 characters; contains 228 characters 59 | WARNING | Line exceeds 80 characters; contains 116 characters 60 | WARNING | Line exceeds 80 characters; contains 104 characters 62 | WARNING | Line exceeds 80 characters; contains 130 characters 63 | WARNING | Line exceeds 80 characters; contains 111 characters 68 | WARNING | Line exceeds 80 characters; contains 96 characters 71 | WARNING | Line exceeds 80 characters; contains 154 characters 74 | WARNING | Line exceeds 80 characters; contains 97 characters 75 | WARNING | Line exceeds 80 characters; contains 153 characters 78 | WARNING | Line exceeds 80 characters; contains 92 characters 80 | WARNING | Line exceeds 80 characters; contains 198 characters 84 | WARNING | Line exceeds 80 characters; contains 88 characters 86 | WARNING | Line exceeds 80 characters; contains 104 characters 87 | WARNING | Line exceeds 80 characters; contains 108 characters 89 | WARNING | Line exceeds 80 characters; contains 331 characters 90 | WARNING | Line exceeds 80 characters; contains 400 characters 97 | WARNING | Line exceeds 80 characters; contains 95 characters 117 | WARNING | Line exceeds 80 characters; contains 125 characters ------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/classy_paragraphs/classy_paragraphs.routing.yml -------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 41 | ERROR | [x] Expected 1 newline at end of file; 2 found -------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/classy_paragraphs/classy_paragraphs.links.menu.yml ----------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Expected 1 newline at end of file; 2 found ----------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/classy_paragraphs/src/Plugin/EntityReferenceSelection/ClassyParagraphsSelection.php -------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------- 69 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 77 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 87 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 87 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead -------------------------------------------------------------------------------------------------------------------------------------------------------- Time: 286ms; Memory: 10MB ➜ contrib git:(main) ✗Thank you.
- Status changed to Needs review
7 months ago 8:08am 7 June 2024