Deprecate PasswordInterface::check() in favour of ::verify()

Created on 18 November 2016, almost 8 years ago
Updated 15 October 2023, 12 months ago

Problem/Motivation

Split from πŸ“Œ Replace custom password hashing library with PHP password_hash() Fixed (see comment #161 β†’ ).

After πŸ“Œ Replace custom password hashing library with PHP password_hash() Fixed , only PasswordInterface::check() has a naming not aligned to PHP >=5.5.0 password hashing functions. The corresponding name should be ::verify() corresponding to PHP password_verify().

Proposed resolution

Because we want to keep BC...

  1. Add a new interface
    interface PasswordHashInterface extends PasswordInterface {
      public function verify($password, $hash);
    }
    
  2. Deprecate PasswordInterface::check()
  3. Use ::verify() everywhere in core instead of ::check()

A starting point is the interdiff.txt from #1845004-162: Replace custom password hashing library with PHP password_hash() β†’ .

Remaining tasks

None.

User interface changes

None.

API changes

New interface

interface PasswordHashInterface extends PasswordInterface {
  public function verify($password, $hash);
}

Data model changes

πŸ“Œ Task
Status

Needs work

Version

11.0 πŸ”₯

Component
BaseΒ  β†’

Last updated 42 minutes ago

Created by

πŸ‡·πŸ‡΄Romania claudiu.cristea Arad πŸ‡·πŸ‡΄

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024