- π§πͺBelgium kriboogh
Updated the summary proposed resolution.
Since #39, several people have tested the patches. #49 also has been verified. So I propose we set this back to RTBC, so this issue can be closed finally.
The last submitted patch, 49: 2816447-49.patch, failed testing. View results β
- Status changed to Needs work
about 1 year ago 3:48pm 3 August 2023 - π©πͺGermany jurgenhaas Gottmadingen
Re-rolled #49 by removing the first code block which is completely unrelated and got removed from core by #3162827: Do not instantiate entity storages in constructors of services that do not always need them β - this should not be brought back and isn't required for this issue either. I guess this got in accidentally.
- last update
about 1 year ago 29,930 pass, 9 fail - last update
about 1 year ago 29,930 pass, 9 fail - Status changed to Needs review
about 1 year ago 4:25pm 3 August 2023 - π¨π¦Canada joseph.olstad
If the tests pass, this should be re-marked as RTBC
- Status changed to Needs work
about 1 year ago 6:09pm 3 August 2023 - Merge request !8987Issue #2816447 by kriboogh: Get feed title in correct language β (Open) created by kriboogh
- π§πͺBelgium kriboogh
Created MR with patch from #58.
Let's see if the tests fail or not. - Status changed to Needs review
about 2 months ago 5:56am 1 August 2024 - π§πͺBelgium kriboogh
MR with patch from #58 and fixed remaining issues. Please review.
- Status changed to Needs work
about 2 months ago 1:11pm 1 August 2024 - Status changed to Needs review
about 2 months ago 11:29am 2 August 2024 - Status changed to RTBC
about 1 month ago 12:42am 4 August 2024 - Status changed to Needs work
about 1 month ago 6:52am 14 August 2024 - π³πΏNew Zealand quietone New Zealand
Thanks for fixing this issue.
@kriboogh, can you comment in the issue the reasoning for the changes you make? Sometime to commit message is enough to provide a clue, but here the message is always the same. It does help reviewer to know what it being done and why.
I left comments in the MR that need attention. This is adding deprecations so there should be a change record and the URL for that change record is to be in the deprecation message. And 10.4 is a maintenance minor β so I think this will be deprecated in 11.1.