Switch from deprecation notice to warning for non-standard placeholders in FormattableMarkup::placeholderFormat()

Created on 28 September 2016, about 9 years ago

Updated 12 March 2023, over 2 years ago

See #2807705: FormattableMarkup::placeholderFormat() can result in unsafe replacements → . We've supported placeholders that don't start with @, !, % or : forever (! was removed in Drupal 8). We no longer support them.

In Drupal 8 we trigger 2 different errors.

If the placeholder starts with a non alphanumeric error then we trigger a E_USER_ERROR.
If the placeholder start with an alphanumeric character AND is in contained in the string then we trigger a E_USER_DEPRECATED.

Trigger a silenced E_USER_DEPRECATION if the placeholder is not in the string and starts with an alphanumeric character. This situation was not accounted for in Drupal 8 so we need to follow our deprecation policy.
For all other occurrences of non standard placeholders trigger a E_USER_WARNING on all non standard placeholders passed to \Drupal\Component\Render\FormattableMarkup::placeholderFormat(). E_USER_WARNING is chosen because we do not do the replacement and therefore there are no risks in continuing on. This is slightly less strict than the current behaviour of issuing an E_USER_ERROR but this is a better experience for real sites. The error will be logged but the site will continue to work. This is unlikely to be a critical error.

None

None

📌 Task

Status

Fixed

Version

9.1

Component

Base →

Last updated about 2 months ago

Created by

🇬🇧United Kingdom alexpott 🇪🇺🌍

Live updates comments and jobs are added and updated live.

Security improvements
It makes Drupal less vulnerable to abuse or misuse. Note, this is the preferred tag, though the Security tag has a large body of issues tagged to it. Do NOT publicly disclose security vulnerabilities; contact the security team instead. Anyone (whether security team or not) can apply this tag to security improvements that do not directly present a vulnerability e.g. hardening an API to add filtering to reduce a common mistake in contributed modules.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 2 years ago →
🇺🇸United States David_Rothstein
quietone → credited David_Rothstein → .
Comment over 2 years ago →
🇳🇿New Zealand quietone
Closed 🐛 Broken argument replacements should trigger an E_USER_ERROR, not E_USER_DEPRECATED Closed: duplicate as a duplicate, adding credit.
Comment over 2 years ago →
🇺🇸United States tr Cascadia
This is still causing problems. Please see 🐛 False positives when identifying what is a placeholder, for deprecation error Fixed . In short, the PSR-3 $context parameter holds more than just placeholders, but Drupal generates a warning if the array keys in $context don't conform to the "placeholder" requirements.

Production build 0.71.5 2024