The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India nikhil_110
Tried to apply patch drupal-file_scan_include_directories-2783389-1.patch but getting some error so I created new patch for Drupal 10.1.x
array $whitelist = [] is replaced by array $allowedExtensionTypes = [] in __construct functions
git apply -v drupal-file_scan_include_directories-2783389-1.patch Checking patch core/lib/Drupal/Core/Extension/Discovery/RecursiveExtensionFilterIterator.php... error: while searching for: * (optional) Add to the blacklist of directories that should be filtered * out during the iteration. */ public function __construct(\RecursiveIterator $iterator, array $blacklist = []) { parent::__construct($iterator); $this->blacklist = array_merge($this->blacklist, $blacklist); } /** error: patch failed: core/lib/Drupal/Core/Extension/Discovery/RecursiveExtensionFilterIterator.php:90 error: core/lib/Drupal/Core/Extension/Discovery/RecursiveExtensionFilterIterator.php: patch does not apply Checking patch core/lib/Drupal/Core/Extension/ExtensionDiscovery.php... Hunk #1 succeeded at 414 (offset -19 lines).
- last update
over 1 year ago 29,304 pass - Status changed to Needs review
over 1 year ago 12:12pm 24 April 2023 - Status changed to Needs work
over 1 year ago 3:40pm 26 April 2023 - 🇺🇸United States smustgrave
Issue summary could use some attention.
This will need a change record and test coverage.