Parent setting on Form display cannot be changed for custom Content type

As per #3 this doesn't seem to make sense to have in core. Perhaps fieldgroup and other modules can alter this to add support. Attaching a patch to remove the parent column / fields and see what breaks.

Fix phpstan issues

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

Can the issue summary be updated? Makes reference for Drupal 8.0.5, just want to confirm Drupal 10.1.x is still valid. Also some TBD were in there.

As a bug will need a test case as well.

Thanks!

Would this not break fieldgroup module pretty hard? Can we just prevent it from erroring as it stands?

Uploading another patch that should fix the test failures.

Note that this completely removes the "parent" concept as I haven't be able to find where it's used in core, and I suspect passing tests will reveal that it's not, or it's at least not covered. Fieldgroup would likely need its own customisations to allow for choosing a parent.

The last submitted patch, 15: 2699907-15.patch, failed testing. View results →

Maybe it should better be solved the other way around, looking at the many benefits it would bring, especially for entity forms: ✨ Add field grouping to core Needs work

Also see
🐛 Field UI: Parent-child relationships not properly updated when fields are moved via drag-and-drop Active
🐛 Child fields moved from disabled groups retain parent relationship Active
which are related here.

Should we perhaps postpone this one on a decision on ✨ Add field grouping to core Needs work ?

Yeah, removing this isn't really an option tbh, I'll have a look at this over the weekend.