The Needs Review Queue Bot β tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- @joachim opened merge request.
- Status changed to Needs review
almost 2 years ago 5:30pm 15 February 2023 - Status changed to RTBC
almost 2 years ago 12:27pm 15 March 2023 - π©πͺGermany Grevil
LGTM!
The patch applies successfully to 10.1.x and works as expected!
Message for invalid "localhost" or empty host option:
Message for incorrect "unix_socket" entry:
Message for general invalid host option:
RTBC!
- π©πͺGermany Grevil
Although, I am unsure about the unix socket mentioning inside the first screenshot, for the
if (isset($connection_options['host']) && in_array(strtolower($connection_options['host']), ['', 'localhost'], TRUE))
Case. Maybe someone with more insight could have a look. - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Adding issue credits
-
larowlan β
committed 9a625bf8 on 10.0.x
Issue #2610858 by cilefen, ravi.shankar, Cameron Tod, shubham.prakash,...
-
larowlan β
committed 9a625bf8 on 10.0.x
-
larowlan β
committed 442c0e41 on 10.1.x
Issue #2610858 by cilefen, ravi.shankar, Cameron Tod, shubham.prakash,...
-
larowlan β
committed 442c0e41 on 10.1.x
- Status changed to Downport
almost 2 years ago 5:17am 21 March 2023 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Committed to 10.1.x and 10.0.x, it doesn't apply cleanly to 9.5.x so marking for backport.
Thanks folks
Added a patch for Drupal 9.5.x, and also added reroll diff between MR and the new patch, please review.
- Status changed to Fixed
over 1 year ago 9:47am 26 May 2023 - π¬π§United Kingdom catch
There's a fair amount going on here and we're approaching the final bugfix release for 9.5.x, so I think we should leave this fixed in 10.0.x.
- π©πͺGermany Anybody Porta Westfalica
Thanks @catch!
Removing "[Needs backport]" from the title so. Automatically closed - issue fixed for 2 weeks with no activity.