Replace a class in forum-list.html.twig to mach naming convention

Created on 14 September 2015, almost 9 years ago
Updated 2 May 2024, about 2 months ago

Problem/Motivation

While I was dealing with #2560231: Replace a class in forum-list.html.twig with a BEM class. → I noticed that all but the first cell of the forum list table use the .forum__[element] naming convention. The first cell has the class .forum-list__forum which differs from its siblings naming pattern.

Proposed resolution

Add the .forum__info class to Classy's template to replace .forum-list__forum . Check that no other CSS exists styles the forum name with the current selector in HEAD.

Remaining tasks

User interface changes

none

API changes

none

Data model changes

none

Beta phase evaluation

<!--Uncomment the relevant rows for the issue. -->
📌 Task
Status

Needs work

Version

1.0

Component
Other  →

Last updated 1 minute ago

Created by

🇭🇺Hungary thamas Hungary

Live updates comments and jobs are added and updated live.
  • CSS

    It involves the content or handling of Cascading Style Sheets.

  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Status changed to Needs work over 1 year ago
  • Status changed to Needs review over 1 year ago
  • Status changed to RTBC over 1 year ago
  • 🇺🇸United States bnjmnm Ann Arbor, MI

    If this change is going to happen, it should also happen with the other themes doing this: Olivero and Umami

    I'd like to suggest changing this to "won't fix" If this landed when the issue was created in 2015 (Drupal 8 was still in beta) I'd be all for it. ~7 years in, the risks of disrupting an existing site with the classname change (however unlikely) still seems to outweigh the benefits of changing the class name many years later.

  • Status changed to Needs work over 1 year ago
  • 🇺🇸United States smustgrave

    @bnjmnm could this almost be a policy that we should avoid adding new classes to core templates? Will post to #frontend to get a theme API maintainer thought.

  • 🇫🇮Finland lauriii Finland

    I don't think this is actually a theme system issue so moving to the other component. I agree that benefits of the change would be minimal. Regardless of that, to me, it seems fine to fix this in the product themes (Claro, Olivero, and Umami). It's allowed by the BC policies of these themes. Also, based on the contrib search, it doesn't seem like this would break anything in contrib.

  • 🇺🇸United States bnjmnm Ann Arbor, MI

    could this almost be a policy that we should avoid adding new classes to core templates

    We do want the flexiblity to change stuff in the product themes. Starterkit (and Stable/Stable9) exist to provide markup predictability for sites that need it so we have freedom in Claro/Olivero/etc. My reservations are specific to this specific use case because I'm not convinced there's any noticeable benefit to making such a change in 2023, yet there's a slight chance this being an unwelcome disruption to someone.

    But ultimately, if another committer and/or FEFM thinks it fine and this lands, I'm fine with it. While it's true I'm expressing an opinion regarding where this issue goes, that opinion is positioned much closer to indifference than it is "strongly agree"

  • Issue was unassigned.
  • 🇳🇿New Zealand quietone New Zealand

    This now belongs if the Forum contrib module.

Production build 0.69.0 2024