Use RecursiveCallbackFilterIterator instead of the $acceptTests parameter forwarding

Seems to be having some build issues. Not seen that one before.

Update for 10.1 and added deprecation test, locally it works))

--- Expected
+++ Actual
@@ @@
-'core/modules/mysql/src/Driver/Database/mysql/'
+'subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/subdirectory/core/modules/mysql/src/Driver/Database/mysql/'

something is wrong, 7 tests failed

This way it pass locally Drupal\Tests\Core\Database\DatabaseTest and more inline with previous implementation

And a bit of clean-up

The last submitted patch, 28: 2532228-28.patch, failed testing. View results →

Deprecation test looks good.

Think this would need it's own change record though. https://www.drupal.org/node/3162143 → doesn't appear to address what's happening here.

Added CR

Lightning speed!

Changes look good to me.

The last submitted patch, 32: 2532228-32.patch, failed testing. View results →

Random ckeditor triggering tests again.

The last submitted patch, 32: 2532228-32.patch, failed testing. View results →

Requeued

Doing RTBC queue triage.

The change record should have more detail. A before and after section with a code example is usually included for deprecations to help the developer. Adding tag.

+++ b/core/lib/Drupal/Core/Extension/Discovery/RecursiveExtensionFilterCallback.php
@@ -83,17 +81,21 @@ class RecursiveExtensionFilterIterator extends \RecursiveFilterIterator {
+  public function __construct(array $skipped_folders = [], $accept_tests = FALSE) {

Shall we type hint $accept_tests.

The deprecation style done here is for Abstract classes, interfaces, traits, and classes with a private constructor → but the constructor is not private. I think this should be using the style for concrete classes → .

I did not do a thorough review of the code.

Updated CR, switched to MR-workflow (note: first commit was a straight-up reroll of patch #32 📌 Use RecursiveCallbackFilterIterator instead of the $acceptTests parameter forwarding Fixed ), type-hinted the living daylights out of all and everything and switched to the recommended deprecation-through-constructor.

I think I've addressed all concerns raised by @quietone in #38 📌 Use RecursiveCallbackFilterIterator instead of the $acceptTests parameter forwarding Fixed , so put this on NR.

Deprecation looks good and CR has the requested before/after section so moving back to RTBC.

Some nitpicky comments, but I think we can perhaps remove the acceptTests() method entirely and simplify this a bit.

Thanks @longwave, resolved all threads.

Seems the threads by @longwave have been resolved.

Committed c343195 and pushed to 11.x. Thanks!

Also published the change record.

Spokje → closed merge request !4312

Automatically closed - issue fixed for 2 weeks with no activity.