Follow-up: Enable additional tests for base entity field access checking in Views

Created on 2 April 2015, over 9 years ago
Updated 27 June 2023, over 1 year ago

As a follow-up to #2462589: Provide test coverage for access checking of all views fields. β†’ ... That issue created generic tests to validate that base entity fields obeyed entity access rules when used in views.

However, when that patch was created, not all of the base entity fields were included, because they would have at that time failed the tests.

So, once all of the critical "convert this field to use an Entity-aware formatter in Views" issues on #2393339: [META] Make sure Views base fields are using Field API for formatting, and do not lose functionality β†’ are fixed, we need to come back here and make sure all the entity base fields for all our entities are covered.

Novice task

Start with the patch in comment #8. See comment #12 for instructions.

πŸ“Œ Task
Status

Needs work

Version

11.0 πŸ”₯

Component
ViewsΒ  β†’

Last updated 21 minutes ago

Created by

πŸ‡ΊπŸ‡ΈUnited States jhodgdon Spokane, WA, USA

Live updates comments and jobs are added and updated live.
  • VDC

    Related to the Views in Drupal Core initiative.

  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡«πŸ‡·France andypost
    1. +++ b/core/modules/aggregator/tests/src/Kernel/Views/AggregatorItemViewsFieldAccessTest.php
      @@ -45,8 +45,7 @@ public function testAggregatorItemFields() {
      -    // @todo Expand the test coverage in https://www.drupal.org/node/2464635
      ...
      +    // Still needs coverage for: iid, fid, link, author, timestamp, guid.
      

      Should be added

    2. +++ b/core/modules/comment/tests/src/Kernel/Views/CommentViewsFieldAccessTest.php
      @@ -67,9 +79,11 @@ public function testCommentFields() {
           // @todo Expand the test coverage in https://www.drupal.org/node/2464635
      -
      +    // Still needs coverage for: pid,entity_id
      

      too

    3. +++ b/core/modules/file/tests/src/Kernel/Views/FileViewsFieldAccessTest.php
      @@ -52,8 +52,6 @@ public function testFileFields() {
      -    // @todo Expand the test coverage in https://www.drupal.org/node/2464635
      

      The test group also needs fix to "file" module

Production build 0.71.5 2024