PoStreamWriter tries to throw an exception of unknown class

Created on 9 January 2015, over 9 years ago
Updated 13 February 2023, over 1 year ago

Problem/Motivation

When an error in PoStreamWriter occurs an exception is supposed to be thrown. The exception class does not exist, however, which then fatals directly and additionally masks the error.

Proposed resolution

Throw a \RuntimeException.

Additionally the patch fixes 3 code style issues in PoStreamWriter:

  1. Using {@inheritdoc}
  2. Documenting an undocumented variable
  3. Remove unnecessary use statements
πŸ› Bug report
Status

Needs work

Version

10.1 ✨

Component
BaseΒ  β†’

Last updated about 2 hours ago

Created by

πŸ‡©πŸ‡ͺGermany tstoeckler Essen, Germany

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request β†’ as a guide.

    Can we get a simple test to show this exception is returned with the change.

    Thanks.

Production build 0.71.5 2024