Add an isComputed method to field handlers

Open on Drupal.org →

Created on 3 October 2014, about 10 years ago

Updated 29 August 2024, 3 months ago

Problem/Motivation

All field handlers that provide things like links do not want to do anything to affect the views query. So the current 'API' for this is just overriding the query() method and leaving it empty, so the parent does not get called. It would be nicer to make this explicit, like click sort is declared.

Additionally, other Views plugins need to be able to determine whether or not a field handler influences the query, since those plugins might rely on the fact that the field handler adds one or more fields to the query. See #2401953: Database exception for View with Combined field filter with fields with no query alias → for an example of this scenario.

Task because computed fields always existed, at least on a implicit level.

Proposed resolution

Add an isComputed() method to FieldPluginBase, this would default to false. Handlers could then either add 'computed' to the views data implementation using the handler or just overriding the method. The base query method can then check this property.

Remaining tasks

- Address issue comments by updating issue summary about why issue is in Needs work status and add these to Remaining tasks.
- Add a merge request for 11.x branch so that tests run and test-only job can run.

User interface changes

?

API changes

?

📌 Task

Status

Needs work

Version

11.0 🔥

Component

Last updated about 4 hours ago

Maintained by
🇩🇪Germany @dawehner
🇺🇸United States @tim.plunkett
🇬🇧United Kingdom @damiankloip
🇺🇸United States @xjm
🇳🇱Netherlands @Lendude

Created by

🇬🇧United Kingdom damiankloip

Live updates comments and jobs are added and updated live.

VDC
Related to the Views in Drupal Core initiative.

DX (Developer Experience)
Enhances developer experience.

Dublin2016

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Needs issue summary update
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 10 months ago →
🇺🇸United States webdrips
Rerolling #82 for 10.2
Comment 10 months ago →
🇺🇸United States webdrips
Comment 10 months ago →
🇺🇸United States webdrips
Ignore last patch; let's try this again
Comment 10 months ago →
🇺🇸United States webdrips
Comment 10 months ago →
🇺🇸United States webdrips
Third time is a charm: re-roll for 10.2
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update 10 months ago
25,821 pass, 1,793 fail
Comment 5 months ago →
🇺🇸United States webdrips
Re-roll for 10.3.0
Comment 3 months ago →
🇺🇸United States webdrips
Re-roll for 10.3.2

Is anyone ever going to commit this ten year old issue? How can we get more attention on this issue?
Comment 3 months ago →
🇺🇸United States mradcliffe USA
We can start by creating an issue fork and merge request for 11.x, and the issue is in Needs work based on comments above. Once in Needs review, it might help to add this to the Needs Review Queue Initiative or discuss in an appropriate Slack channel.

I removed the beta table adjusting the issue summary to compensate because that was something we did specifically for Drupal 8 and no longer applies.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024