#2247779: Allow #pre_render, #post_render and #post_render_cache callbacks to be service methods →
made it possible to use service methods as #pre_render, #post_render and #post_render_cache callbacks.
Sadly, it includes this very confusing hack. dawehner said that this was necessary ( #2247779-12: Allow #pre_render, #post_render and #post_render_cache callbacks to be service methods → ):
if (strpos($callback, '::') == FALSE) {This sadly is needed at the moment because there are callbables like 'Drupal\comment\CommentViewBuilder::attachNewCommentsLinkMetadata' which sadly don't implement ContainerFactoryInterface
but EntityControllerInterface
At the time we deferred clarifying this to a follow-up (because it blocked other issues), but we forgot to do so. This confusing check again surfaced in a code review of an unrelated patch at #2273277-19: Figure out a solution for the problematic interaction between the render system and the theme system when using #pre_render → , point 2, so it's about time we fix this.
Remove this check if possible, otherwise at least clearly document it.
TBD
None.
None.
Closed: outdated
11.0 🔥
Last updated
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
\Drupal\Core\Render\Renderer::doCallback now uses the callable resolver, 📌 Use CallableResolver for \Drupal\Core\Render\Renderer::doCallback() Needs work . So, there is no need to add documentation and this is outdated.
There is a related issue about standardizing callbacks that may be of interest, [#2982950.