- ๐ณ๐ฟNew Zealand quietone
This extension is being deprecated, see ๐ฑ [Meta] Tasks to deprecate Tour module Fixed . It will be removed from core and moved to a contrib project, ๐ [11.x] [Meta] Tasks to remove Tour Postponed .
This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project โ and the Extensions approved for removal โ policies.
- Status changed to Needs work
7 months ago 10:28pm 5 May 2024 - ๐บ๐ธUnited States smustgrave
So we probably could add a Tour settings page where we turn of the auto scrolling
Or do some alter hook to the user edit form?
Thought?
- ๐บ๐ธUnited States charles belov San Francisco, CA, US
Actually, this issue is probably obsolete. If Tours were to respect prefers-reduced-motion, then there would be no need for a separate setting.
- ๐บ๐ธUnited States charles belov San Francisco, CA, US
It appears that I never filed this with with joyride. I have now filed this as Respect prefers-reduced-motion #241
- ๐บ๐ธUnited States thejimbirch Cape Cod, Massachusetts
Tours no longer use Joyride. That was deprecated as I believe it is no longer supports.
Tour now uses the Joyride library. I filed an issue there back in 2021.
https://github.com/shepherd-pro/shepherd/issues/1652
It may be possible for this module to add the needed functionality. I am not that much of a JavaScript person to figure that out though.
- Assigned to smustgrave
- Merge request !48Issue #2312805 by charles belov, nod_, mgifford, thejimbirch, smustgrave: Tour... โ (Merged) created by smustgrave
- Status changed to Needs review
3 months ago 1:31pm 26 August 2024 - Status changed to Needs work
3 months ago 1:55pm 26 August 2024 - ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
hm in MR48 if "reduce motion" is active on the operating system level (macOS on my end) the scrollTo event is set to false (if i read it correctly). problem with this as illustrated in the video, in some cases the highlighted component the tour tip is referring to is outside the viewport, in one case the highlighted component AND the tour tip is outside the viewport.
- ๐บ๐ธUnited States smustgrave
Yes the ticket mentions turning off scrolling.
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
hm but by entirely turning off the scrolling the information is getting lost. if i remember correctly from the other issue you'Ve closed as duplicated you've mentioned that shepherd doesn't have any css animations? is that scrolling entirely javascript based then? is that the reason when the scrollTo is omitted that the focus doesn't just jump? would it be possible to have a progressive enhancement, meaning it just jumps without animation and if the operating system has no preference for the reduced motion media query (
@media (prefers-reduced-motion: no-preference)
), the animation related parts would become active? - Status changed to Needs review
3 months ago 1:39pm 28 August 2024 - ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
now it looks like the system settings are minded, see reduce_motion.mp4. Curious what @charles belov thinks about the current MR?
- ๐บ๐ธUnited States charles belov San Francisco, CA, US
Happy to test on simplytest.me if someone can point me to instrux and a sample tour. Not a developer here, I'm Quality Assurance.
- ๐บ๐ธUnited States charles belov San Francisco, CA, US
Please split the example video into two videos, one with motion and one with the reduce-motion setting. I didn't know what I was getting into and the motion part of the video made my eyes feel ill.
The non-motion part is likely what I'm seeking, but until my eyes calm down (and you provide a reduced-motion-only video that I can safely watch) I'm not in a position to judge.
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
argh apologies for the video, THAT shouldnt have happened!:( i've followed your suggestion and uploaded two separate files, reduced_motion.mp4 and full_motion.mp4.
for changing the file name for already uploaded files i see no option. but i'll add a warning to the comment containing the video.
and in regards of simplytestme i am not sure if it is possible. i've just checked and the tour project isnt found there. i could share a local instance with the MR applied and send the link your way tomorrow if you want to.
and another time sorry for the oversight with the video :((((
- ๐บ๐ธUnited States charles belov San Francisco, CA, US
Thank you.
I've viewed the reduced motion video. It went by a little fast (I wound up watching it at half speed) but I'm able to suss out some comments.
The question with reduced motion can sometimes be that there was some advantage with the motion that needs to be replaced in a safe way. Here, the point would be that with long pages, it may be hard to tell where you are on the page, and whether you went up or down to get there. This is relevant to a tour, because the visitor needs to be able to replicate the action.
While your demo video has scroll bars, and I have my scroll bars set to always on, some operating systems (in my case macOS) allow setting the scroll bars to only display when you need them. So people who have that setting may not be able to tell where the particular tour point of interest is on the page. So they trade information for safety.
I don't want to over-engineer this, but such people might need a brief arrow cue that we are going down the page. Maybe even one arrow for a short distance or three for a long distance. Maybe the arrow would fade in and out.
- ๐บ๐ธUnited States smustgrave
So question is do we merge this or hold on the other feature. I donโt know how long that could take
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
@charles belov, i am on macos as well, and i also have set safari to always show the scrollbar. but i've just tested with the two other options available "when scrolling" and "automatically based on mouse or trackpad", the scrollbar is shown and rather quickly fades out right after the position changed for the next tour tip. so at least for macos the user would have a certain contextual awareness. but i am not sure how other operating systems handle the showing and hiding of the scrollbar.
so getting to the question from @smustgrave i wonder if it would make sense to commit the current state of the MR and open a followup issue for the contextual information charles suggested? cuz the module not minding the operating system setting for reduce motion shouldnt be kept up much longer imho? - ๐บ๐ธUnited States smustgrave
If someone can open that follow up will merge it
- ๐บ๐ธUnited States charles belov San Francisco, CA, US
@rkoller @smustgrave I concur. I would be unable to reproduce the issue, so I am not that one to file the second issue if there's not an easy way to reproduce on the Mac.
- ๐บ๐ธUnited States smustgrave
Opened ๐ Accessibility add an arrow cue that page is scrolling down or up Active and merged this!
- Status changed to Fixed
3 months ago 2:24pm 30 August 2024 -
smustgrave โ
committed d2468eea on 2.0.x
Issue #2312805 by charles belov, nod_, mgifford, thejimbirch, smustgrave...
-
smustgrave โ
committed d2468eea on 2.0.x
Automatically closed - issue fixed for 2 weeks with no activity.