Selectors clean-up: filter module

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rerolled the patch for the D10.1.x, as #29 is no longer compatible with D10. Attaching reroll_diff Along with patch.

1. +++ b/core/modules/filter/filter.admin.js
   @@ -36,7 +36,7 @@
   +          if ($checkbox.prop(':checked')) {
   
   @@ -60,7 +60,7 @@
   +            $checkbox.prop(':checked')
   

   There shouldn't be a ":" in there. I do not think the code as-is work.

2. +++ b/core/modules/filter/filter.js
   @@ -25,8 +25,8 @@
   +      $(once('filterGuidelines', '.js-filter-guidelines', context))
   

   There shouldn't be a need to change the once id here.

Addressed #42 re uploading the patch and reroll_diff

Manually tested the filter admin interface as well as the text format change behavior, both work as expected.

The last submitted patch, 43: 1751388-43.patch, failed testing. View results →

second time getting this migratestub failure

The last submitted patch, 43: 1751388-43.patch, failed testing. View results →

+++ b/core/modules/filter/filter.js
@@ -26,7 +26,7 @@
-        .find(':header')

This is the remaining change in the patch that could be applied. This change is also in 📌 Refactor (if feasible) uses of the jQuery sizzle to use vanillaJS Needs work .

Perhaps this should be closed as a duplicate and move credit?

removing Novice tag as it isn't too clear what the next action is

Agree with #49