- Issue was unassigned.
- ๐ณ๐ฟNew Zealand quietone
I rebased the MR onto 11.x but there are errors to fix.
- First commit to issue fork.
- Status changed to Needs review
4 months ago 2:41pm 5 August 2024 - Status changed to Needs work
4 months ago 4:11pm 5 August 2024 - Status changed to Needs review
4 months ago 12:26pm 6 August 2024 - Status changed to RTBC
3 months ago 7:14pm 11 August 2024 - ๐บ๐ธUnited States smustgrave
Ran test-only feature
1) Drupal\Tests\locale\Functional\LocaleImportFunctionalTest::testStandalonePoFile Behat\Mink\Exception\ResponseTextException: The text "The file is not encoded with UTF-8" was not found anywhere in the text of the current page. /builds/issue/drupal-1630568/vendor/behat/mink/src/WebAssert.php:907 /builds/issue/drupal-1630568/vendor/behat/mink/src/WebAssert.php:293 /builds/issue/drupal-1630568/core/tests/Drupal/Tests/WebAssert.php:975 /builds/issue/drupal-1630568/core/modules/locale/tests/src/Functional/LocaleImportFunctionalTest.php:257 FAILURES! Tests: 6, Assertions: 136, Failures: 1.
Which shows the coverage.
Believe all feedback on the MR has been addressed.
- Status changed to Needs work
3 months ago 8:51am 20 August 2024 - ๐ณ๐ฟNew Zealand quietone
This is almost there. I left a few comments to look at.
- Status changed to Needs review
3 months ago 2:23pm 20 August 2024 - ๐ซ๐ฎFinland sokru
I think other threads are solved, but still open to suggestions if the FileEncoding constraint $encoding should be list of encodings.
- ๐ณ๐ฟNew Zealand quietone
Sorry that I missed that this will need tests of the new constraint validator.
- ๐ซ๐ฎFinland sokru
I added tests for FileEncodingConstraint. Instead of list I converted $encoding into an array, IMO it makes the code cleaner: no need for
implode
orpreg_*
that FileExtensionConstraint is using. - ๐บ๐ธUnited States nicxvan
I reviewed this and it looks great.
All of the threads seem to be resolved.
I tried to run the test only job, but it wouldn't run due to:
This job could not start because it could not retrieve the needed artifacts.
Learn more about dependencies and common causes of this error.The actual tests are passing.
- Status changed to RTBC
3 months ago 1:44pm 5 September 2024 - ๐บ๐ธUnited States smustgrave
Rebased and got test-only to run https://git.drupalcode.org/issue/drupal-1630568/-/jobs/2659732
Re-looking at believe all feedback has been addressed
-
alexpott โ
committed a61ad676 on 11.x
Issue #1630568 by sokru, Laureatus, quietone, smustgrave, ravi.shankar:...
-
alexpott โ
committed a61ad676 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.