Misleading error message when uploading a file

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

At this time we will need a D10 version of the patch.

Tagging for IS update for proposed solution and remaining tasks.

Rerolled for 10.1.x

Thank you for working on this.

When uploading patches please include an interdiff file also

Moving back to NW for the issue summary update.

My bad, I couldn't attach an interdiff duo to the error below:

1 out of 1 hunk FAILED -- saving rejects to file /tmp/interdiff-1.BEe0qz.rej
interdiff: Error applying patch1 to reconstructed file

But the only difference was that I kept the new D10 statusMessageContainsAfterWait(message, 'error') over the patch's pageTextContains.

No worries!

I occasionally get that myself. For those what I do is diff old.patch new.patch > diff-[old-patch-number]-[new-patch-number].txt

In the first hunk, the @size token is removed from the text, so it should not be set in the arguments.

That's right! @size's arguments removed. I took the opportunity to add a final point that was missing.

And what about these comments?

// Render a nice error message in case we have a file upload which exceeds
// the configured upload limit.

Should we change them too?

// An error message should appear informing the user that the file exceeded
// the maximum file size. The error message includes the actual file size
// limit which depends on the current environment, so we check for a part
// of the message.

The last submitted patch, 40: 1452128-40.patch, failed testing. View results →