Contact form opt-out line should be excluded from admin-sent and sender-copy e-mails

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

Won't tag for it but this could use an issue summary update to match the standard template. Not the most clear.

Can verify this problem on D10

Think this needs some work though

Created userA and userB
userB is content editor with permissions to administer user (so they can see users) and permission to contact user
UserA opted out of contact form
Login as userB I would expect to not see the contact tab for userA but I do and can send an email
userA received an email with the

If you don't want to receive such emails, you can change your settings at

Discussed in Slack, I think that the tab access issue mentioned in #85 is out of scope, this issue is to address the email text only. And if the email text is corrected, it's not unexpected that admins can view your contact tab, because as the OP notes, admins can still contact you even if you have opted out.

So in the interest of seeing this resolved, I think it should only be concerned with the email content.

MR created.

Hiding patches for clarity.

Ran test-only feature

1) Drupal\Tests\contact\Functional\ContactPersonalTest::testPersonalContactForm
Opt-out message included in email.
Failed asserting that false is true.
/builds/issue/drupal-124969/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121
/builds/issue/drupal-124969/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
/builds/issue/drupal-124969/core/lib/Drupal/Core/Test/AssertMailTrait.php:100
/builds/issue/drupal-124969/core/modules/contact/tests/src/Functional/ContactPersonalTest.php:376
/builds/issue/drupal-124969/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
FAILURES!

As mentioned in slack #85 is out of scope for this issue and can be ignored.

Issue summary is clear about the problem and steps to show the issue.

When applying the MR and following the steps I get the expected behavior.

Believe this long standing bug is good to go.

Committed and pushed 1dbf2cc2ea to 11.x and e1a29d0851 to 10.3.x and 5fa98acae9 to 10.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.