🇬🇧United Kingdom @kiwimind

Agree with the approach used on #32. Much nicer to define using spans than calculating values.

Code looks good, shame we're still using 33-34-33 now that it's proper thirds, however I realise that that is perhaps above and beyond. Similar with 33-67.

I've checked the code, but have not had a chance to test, so won't mark as RTBC yet.

Thanks, looking forward to this change that I've often overridden. :)

Couple of minor things I noticed, and a question.

kiwimind → created an issue.

Thanks very much for the prompt response.

I'll have a think about this. If there's time on this project then I may well have a crack, otherwise we may have to rely on revisions by date.

kiwimind → created an issue.

Re-rolled the patch to use null coalescing operator against 2.x.

While this patch works great and removes the error, small DCS change needed before RTBC please.

+++ b/src/Form/CasAttributesSettings.php
@@ -73,12 +73,12 @@ class CasAttributesSettings extends ConfigFormBase {
+    $token_allowed_attributes = is_null($config->get('token_allowed_attributes')) ? array() : $config->get('token_allowed_attributes');

array() should be [] as mentioned https://www.drupal.org/docs/develop/standards/php/php-coding-standards#a... →

greggles → credited kiwimind → .

It seems that $node->status returns an object, so checking against its value seems to solve it.

kiwimind → created an issue.

@quietone having just tested this and also being able to reproduce the issue, I'm interested in the workaround that you mentioned.

I'm not sure what you mean by "group filters". The only way this term currently makes sense to me is when reordering filters and assigning them to groups there. I hope I'm missing something obvious.

Currently without leaning towards custom code I'm unable to see how you might output the field labels rather than the True/False.

Thank you.

Similar to #14. I ended up inserting some CSS via a custom module that seemed to work fine. Quick and simple.

I found that inserting links into e.g. paragraph library items was fine, however inserting them into a rich text paragraph inside layout paragraphs did not display the popup.

Have amended the previous patch to include an extra check to avoid the warning, as well as a little code style clean up and amending the text being output about the reference being deleted.

I'm not 100% sure on whether $usage['file'] is enough or whether we should be looking at what else is passed, e.g. $usage['editor'], however this does remove the warning.

Having added the patch from #26, there are a couple of warnings showing.

Warning: Undefined array key "file" in Drupal\file_delete\Form\FileDeleteForm->submitForm() (line 167 of modules/contrib/file_delete/src/Form/FileDeleteForm.php).

Warning: foreach() argument must be of type array|object, null given in Drupal\file_delete\Form\FileDeleteForm->submitForm() (line 167 of modules/contrib/file_delete/src/Form/FileDeleteForm.php).

I can't see any reason (yet) why some files cause this and others don't, but thought I'd mention it.

Having taken a look at the D9 patch above, it seems that there's a simple way of amending the styling without changing much else by removing a couple of things.

Please see attached patch for 9.5.x

I've just commented on https://www.drupal.org/project/paragraphs/issues/3161170#comment-15150524 🐛 Dropbutton list items hidden on Claro in vertical tabs Active explaining why.

Have just come across this.

There is an `overflow: hidden` on the element that's wrapping this.

The styling on this comes from /core/themes/claro/css/components/vertical-tabs.css so it's a Claro issue.

Hi @Gauravvvv

Thanks for taking a look.

I've just used simplytest.me to install a clean version of 10.1.0 and you're right, the display is correct.

Interestingly the classes I mentioned in the initial report are present in 10.1.0, however the CSS order is different than what I'm seeing locally, i.e. the button and button--primary classes are taking precedence over ui-widget and ui-button in the cascade.

I'll have a bit more of a dig to see why this might be and report back.

kiwimind → created an issue.

Sorted! Couple of head scratchers in there. Pales in comparison to @mherchel (#11) though :)

Thanks @lauriii, that's great news.

I did have a search and didn't come across that ticket, will take a look and keep an eye on progress.

Thanks again.

kiwimind → created an issue.

Just to throw some more into the mix.

I'm building a pretty standard site at the moment and have exposed a node add form to anonymous users that then throws this error when they create a node. So seemingly nothing to do with Views or a multiple filter, so could it be something else?

I tried adding the patch from https://www.drupal.org/project/drupal/issues/3023924 🐛 Cannot create references to/from string offsets Needs work , and while this did allow the submission to go through without the site-breaking error, it did not appear to allow the submitting values through, as it came back saying that all of the required fields needed to be filled out.

Have tested the patch and it appears to solve one of the issues that I raised on https://www.drupal.org/project/autologout/issues/3361785 🐛 Inconsistent modal behaviour Needs review , so I'm happy that the code does what it's supposed to.

Prior to installing this patch, not only was it using jQuery, but it seemed to be inconsistent with the regularity of displaying the modal. Now it's showing every time.

Going to need to sort out the failing tests though.

kiwimind → created an issue.

Having come across this issue on 9.5.8, applying the patch from https://www.drupal.org/project/drupal/issues/2230909#comment-14626332 🐛 Simple decimals fail to pass validation Needs work has solved this issue.

Prior to the patch we were unable to set a default value of a trillion (1 with 12 zeroes) on a 15,2 decimal field. After the patch it has saved as expected.

Ok, yeah, apologies.

Apparently if you want to use leaflet and also restrict editors to a single marker placement, then enabling Geofield Map does do this.

Thanks.

Sorry to raise this old thread, however it feels relevant again today.

Seeing as the most recent version of the Geofield Map module does not appear to support Leaflet at the display end of things (only on the edit widget unless I'm missing something obvious), then this issue is valid again.

It's still possible for editors to add more than one point to a geofield, and expecting them to select the add marker icon and right click to remove a marker does not feel particularly user friendly when it seems it would be better to replace the marker already placed when clicking on the map a second time.