- πΊπΈUnited States emscha
Is it safe to apply the patch to production?
- First commit to issue fork.
- @alorenc opened merge request.
- π΅π±Poland alorenc Wolsztyn, π΅π±
I got the same error and I have a bit simplified patch #2, used the null coalescing operator.
- Status changed to Needs work
7 months ago 9:07am 15 May 2024 - π¬π§United Kingdom kiwimind
While this patch works great and removes the error, small DCS change needed before RTBC please.
+++ b/src/Form/CasAttributesSettings.php @@ -73,12 +73,12 @@ class CasAttributesSettings extends ConfigFormBase { + $token_allowed_attributes = is_null($config->get('token_allowed_attributes')) ? array() : $config->get('token_allowed_attributes');
array()
should be[]
as mentioned https://www.drupal.org/docs/develop/standards/php/php-coding-standards#a... β - Status changed to Needs review
7 months ago 9:34am 15 May 2024 - last update
7 months ago 20 pass - π¬π§United Kingdom kiwimind
Re-rolled the patch to use null coalescing operator against 2.x.