- Issue created by @alfaguru
- Status changed to RTBC
over 1 year ago 3:20pm 13 February 2023 The last submitted patch, 2: use_drupal_dialog_api-3339695-2.patch, failed testing. View results →
- Status changed to Needs work
about 1 year ago 11:02am 22 May 2023 - 🇬🇧United Kingdom kiwimind
Have tested the patch and it appears to solve one of the issues that I raised on https://www.drupal.org/project/autologout/issues/3361785 🐛 Inconsistent modal behaviour Needs review , so I'm happy that the code does what it's supposed to.
Prior to installing this patch, not only was it using jQuery, but it seemed to be inconsistent with the regularity of displaying the modal. Now it's showing every time.
Going to need to sort out the failing tests though.
- First commit to issue fork.
- last update
9 months ago 15 pass, 7 fail - @deaom opened merge request.
- Status changed to Needs review
9 months ago 10:37am 20 September 2023 - 🇸🇮Slovenia DeaOm
Added the patch to issue fork for easier maintaining. The tests are failing because of the core migration issue 🌱 [META] Serialization issues in Migration tests Active , but the code provided does seem to work, but setting the status to needs review, so somebody else can also again re-test and confirm it's working as expected.
- First commit to issue fork.
Rebased the MR, tests are passing, testing by hand the modal also works fine.
While the patch is the same as the issue fork, I'll hide the file since DrupalCI tests are deprecated, and without the tests fix they will never pass, if you need a patch you can use plain diff or generate a patch file using GitLab.
Setting the issue to RTBC.
- Status changed to RTBC
9 months ago 6:03am 26 September 2023 - Status changed to Needs review
9 months ago 11:49am 28 September 2023 - 🇸🇮Slovenia DeaOm
Changed as much of JQuery to plain JS as I could, also removed the duplicated dialogs appearing when clicking on "Yes" button. There could be an issue of logging out after 10s after first "Yes" in D10, which is covered in 🐛 Drupal 10 second dialog logout Needs review . Needs manual testing to confirm everything is working as expected, the automated test are passing.
- Status changed to RTBC
9 months ago 1:10pm 28 September 2023 Local and gitlabCI tests are passing, testing by hand also works correctly. Just in case locally merged 🐛 Drupal 10 second dialog logout Needs review and that fixed the second dialog instantly closing. With this fix, there is no need for 🐛 Multiple dialogs open Postponed . I think this can be merged.
- 🇺🇸United States jrglasgow Idaho
The fork appears to have merge conflicts, please fix and I will merge them in.