Use Drupal.dialog call instead of jQuery dialog

Tested and this is now working well.

The last submitted patch, 2: use_drupal_dialog_api-3339695-2.patch, failed testing. View results →

Have tested the patch and it appears to solve one of the issues that I raised on https://www.drupal.org/project/autologout/issues/3361785 🐛 Inconsistent modal behaviour Needs review , so I'm happy that the code does what it's supposed to.

Prior to installing this patch, not only was it using jQuery, but it seemed to be inconsistent with the regularity of displaying the modal. Now it's showing every time.

Going to need to sort out the failing tests though.

Added the patch to issue fork for easier maintaining. The tests are failing because of the core migration issue 🌱 [META] Serialization issues in Migration tests Active , but the code provided does seem to work, but setting the status to needs review, so somebody else can also again re-test and confirm it's working as expected.

Rebased the MR, tests are passing, testing by hand the modal also works fine.

While the patch is the same as the issue fork, I'll hide the file since DrupalCI tests are deprecated, and without the tests fix they will never pass, if you need a patch you can use plain diff or generate a patch file using GitLab.

Setting the issue to RTBC.

Changed as much of JQuery to plain JS as I could, also removed the duplicated dialogs appearing when clicking on "Yes" button. There could be an issue of logging out after 10s after first "Yes" in D10, which is covered in 🐛 Drupal 10 second dialog logout Needs review . Needs manual testing to confirm everything is working as expected, the automated test are passing.

Local and gitlabCI tests are passing, testing by hand also works correctly. Just in case locally merged 🐛 Drupal 10 second dialog logout Needs review and that fixed the second dialog instantly closing. With this fix, there is no need for 🐛 Multiple dialogs open Postponed . I think this can be merged.

The fork appears to have merge conflicts, please fix and I will merge them in.

david.muffley → made their first commit to this issue’s fork.

Fixed merge conflicts. Back to you @jrglasgow.

david.muffley → changed the visibility of the branch 8.x-1.x to hidden.

Fixed for 2.0.x-dev

Setting to RTBC for 1.x

This is already fixed in 2.x-dev

ah, maybe not

I am testing this patch with version 2.0.0 and it appears that these changes:

document.dispatchEvent(new Event('preventAutologout'));

are not properly triggering the 'preventAutologout' event. I'm being logged out despite 'mousemove' events triggering.

based on latest report

I've updated the branch to fix the JS scope and event issues I found.

tomtech → changed the visibility of the branch 3339695-use-drupal.dialog-call to hidden.

tomtech → changed the visibility of the branch 3339695-use-drupal.dialog-call to active.

tomtech → changed the visibility of the branch 3339695-use-drupal.dialog-call to hidden.

Hi all,

The MR resolved most of the issues I was also encountering, but the attachBehaviors was firing multiple times. This caused init() to be invoked multiple times stacked. While clicking "Yes" would dismiss the dialog, the subsequent init() calls would still invoke logout shortly thereafter.

The code tries to prevent this by checking if the context is "document", but there can still be multiple attach calls with document as the context.

I've added a commit that uses drupal once, so that the behavior is only attached once, which seems to resolve this issue.

I also add the new classes property, so this works with D10.3.

Lastly, I created a new fork that targets the 2.x branch, given that is the latest version.