Drupal 10 second dialog logout

Created on 27 September 2023, 9 months ago

Updated 4 October 2023, 9 months ago

Problem/Motivation

I don't understand why this module was ever accepted to be D10 compatible. I set the timeout to 70 seconds and left padding at 20 seconds. Login as any user, after 70 seconds the dialog shows up, and I click the button to extend the time after about 30 seconds a new dialog opens for less than a second and instantly logs me out.

I see that there was a D10 compatibility issue that only fixed depreciation problems, but there was not much testing done.

Thanks to the recent fixes added to the dev branch at least the second dialog shows up, without them the module is even more broken.

Steps to reproduce

Install the module and set timeout to 70 seconds
Go to any page
After 70 seconds the dialog shows up, click the button to stay logged in
At this point after some 30 seconds or so, the bug happens, and you'll get logged out

🐛 Bug report

Status

Needs review

Version

1.0

Component

Code

Created by

admirlju

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @admirlju
Status changed to Needs work 9 months ago1:01pm 27 September 2023
Comment 9 months ago →
admirlju
@admirlju opened merge request.
Status changed to Needs review 9 months ago1:21pm 27 September 2023
Comment 9 months ago →
admirlju
I think I figured it out and from quick testing, the fix in the issue fork should also work with Drupal 9.5 but please this needs a lot more testing, and as I mentioned in some other issue the whole JS file needs refactoring.
Comment 9 months ago →
admirlju
So I did some extra tests, and it looks like this change also works with Drupal 9.2.
Comment 9 months ago →
admirlju
Replaced jQuery event listener and dispatcher with vanilla JS, to make it consistent with changes in ✨ Use Drupal.dialog call instead of jQuery dialog RTBC

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024