🇺🇸United States @rocketeerbkw

alexpott → credited rocketeerbkw → .

Thanks all!

Makes sense to opt-in to future versions, and we can address issues as they come up instead of fussing over version numbers.

rocketeerbkw → created an issue.

Removed:

• ymmatt
• vangorra
• panthar
• james.wilson

rocketeerbkw → created an issue.

The "Needs Review" status is used when a patch/merge request is ready to review, but there isn't one yet.

Thanks, I re-worked the README in 📌 Avoid exclusive language Active and credited you over there.

Thanks all, I committed the patch and reworked the README. Moving issue to 7.x for backporting.

Is it just to commit D10 fixes or long term? We already got a new maintainer → , so I'm just a little hesitant to ignore this issue de-facto approve you.

I'll be at DrupalCon, I can commit to getting D10 issues resolved in the short term.

rocketeerbkw → created an issue.

larowlan → credited rocketeerbkw → .

Is the Drush command useful for these libraries? Should that be documented also?

Otherwise the page LGTM.

Updated the IS to reflect the consensus.

TL;DR

For ecaguide.org, I like the simplest version format of incrementing whole numbers: v1 -> v2. It informs users that a model they looked at or used before has changed, and doesn't require contributors to learn and parse changes into a meaningful version.

As I stated in the IS, there's a chance that a format we pick for the guide gets adopted more broadly. In that case I like the custom/semi-semantic format of logic.documentation. It provides some information about what has changed between versions, but requires contributors to correctly map the changes they made into the correct part of the version format.

I'm sure there are other options (like combining date + increment 20220101-1). And maybe there is another category besides (non)-semantic. Would be interested to see other options.

As mentioned in slack, I did some quick googling to see if any BPMN/Camunda resources had recommendations and didn't find anything.

rocketeerbkw → created an issue.

I've created a model and attached it as bpmn_io-eca_lib_0008.tar.gz.

I read the project page and source code for "Redirect 403 To Login Page" to ensure the model isn't missing anything. Note that this model requires the plugins added in ✨ Add data provider for response events Fixed .

The ECA model differs from the module in one way, the following warning is not a problem with the model, it will always redirect on 403:

If you set Default 403 (access denied) page in Basic site settings, this module won't work as expected.

rocketeerbkw → created an issue.

I tested a broken model by adding eca_validation=off and clicking save without making any changes. I got the same error as before. This makes sense since the bad action still exists in the model. Then I deleted the action and clicked save and didn't get any errors. The model was saved correctly. I removed the query parameter and was able to make more changes to the model (now without the bad action).

I tested everything using the BPMN.io modeller, I presume that's what the $isAjax check is for? I haven't tested the other two modellers but the MR appears to handle those correctly.

Closing as duplicate of #881006: Regression: 'break' tag doesn't work with Filtered HTML → . There's a workaround in comment #118 → .

There are TODOs on this page, so certainly it should be marked as needs work?

Also, there was still a reference to EntityWithPluginBagInterface which was removed in D8 → .

I added a calculateDependencies() function to the config request entity. This adds a module config dependency every time a new one is created or updated.

I briefly explored creating a hook_update_n to make this change for all existing HTTP config requests, but I wasn't sure what the best practice is for config entities. I think the typical workflow of importing config in production, then running database updates wouldn't be compatible with this. It would be nice to update existing config entites, and if you know what the correct method of doing it would be, I'll make it happen. But otherwise, I'll say it's a nice to have and not required.

rocketeerbkw → created an issue.

See my comments above.

Add help page and update text on role settings page was the last commit I made four months ago.

Is the script you use to generate these issues open source? I'd like to open an issue of my own.

Added the enforced dependency as described in issue summary.