Dependence on GLOB_BRACE flag which is not universally available

Issue created by @rocketeerbkw
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
771 pass
@phenaproxima opened merge request.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.11 + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
771 pass
Comment about 1 year ago →
🇺🇸United States phenaproxima Massachusetts
Assigned to tedbow
Status changed to Needs review about 1 year ago1:56pm 24 October 2023
Comment about 1 year ago →
🇺🇸United States phenaproxima Massachusetts
Assigning to @tedbow for review. I don't think we need dedicated test coverage here; the issue is OS-specific, and the changes here are purely internal refactoring for compatibility.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
18:27
40:31
Running
Open in Jenkins → Open on Drupal.org →
Core: 10.0.11 + Environment: PHP 8.1 & MySQL 8
24:29
57:07
Running
Assigned to phenaproxima
Comment about 1 year ago →
🇺🇸United States tedbow Ithaca, NY, USA
We couldn't use \Drupal\Core\File\FileSystemInterface::scanDirectory here?

🇺🇸United States phenaproxima Massachusetts

We cannot, because it unconditionally excludes hidden things. This is explicitly documented on the interface:


   * Finds all files that match a given mask in a given directory.
   *
   * Directories and files beginning with a dot are excluded; this prevents
   * hidden files and directories (such as SVN working directories) from being
   * scanned.

Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
771 pass
Status changed to RTBC about 1 year ago4:28pm 24 October 2023
Comment about 1 year ago →
🇺🇸United States tedbow Ithaca, NY, USA
Looks good. I agree the test coverage in `UnknownPathExcluderTest` already covers this
Open in Jenkins → Open on Drupal.org →
Core: 10.0.11 + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
771 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
771 pass
Comment about 1 year ago →
System Message

phenaproxima → committed 6ced02cd on 3.0.x
Issue #3395782 by phenaproxima, rocketeerbkw: Dependence on GLOB_BRACE...
Issue was unassigned.
Status changed to Fixed about 1 year ago4:42pm 24 October 2023
Comment about 1 year ago →
🇺🇸United States phenaproxima Massachusetts
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Dependence on GLOB_BRACE flag which is not universally available

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities