- Issue created by @kunal.sachdev
- Assigned to kunal.sachdev
- @kunalsachdev opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 2:56pm 17 February 2023 - Status changed to RTBC
almost 2 years ago 7:37am 20 February 2023 - ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Thanks for first pushing a commit with only test coverage, showing that that causes the new test coverage to fail and only then pushing the fix ๐ Makes my job as a reviewer very easy! ๐๐
- First commit to issue fork.
-
phenaproxima โ
committed 36f5ecd3 on 3.0.x authored by
kunal.sachdev โ
Issue #3342726 by kunal.sachdev, Wim Leers: UnknownPathExcluder doesnโt...
-
phenaproxima โ
committed 36f5ecd3 on 3.0.x authored by
kunal.sachdev โ
- Status changed to Fixed
almost 2 years ago 3:49pm 21 February 2023 - ๐บ๐ธUnited States phenaproxima Massachusetts
Nice work, and I agree with Wim about the helpfulness of pushing a failing test first. Gratefully and enthusiastically merged!
Automatically closed - issue fixed for 2 weeks with no activity.