- Issue created by @jdleonard
- πΊπΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
I'll take this on.
- πΊπΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
This is ready for review.
- πΊπΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
This is available to preview here: https://issue.pages.drupalcode.org/-/member-3512318/-/jobs/4794928/artif...
- πΊπΈUnited States jdleonard Austin, TX, USA
Looking good! Assigning to me to replace license with GPL 2.0
-
jdleonard β
committed aa9d6409 on 1.0.x authored by
alexdmccabe β
Issue #3512318 by alexdmccabe, jdleonard: Set up MkDocs for docs....
-
jdleonard β
committed aa9d6409 on 1.0.x authored by
alexdmccabe β
- πΊπΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
Sorry. I must have grabbed the wrong license. Good catch.
It lives: https://project.pages.drupalcode.org/member/
Should I mark this as fixed?
- πΊπΈUnited States jdleonard Austin, TX, USA
Just confirmed with drumm that Drupal's GitLab Pages doesn't currently support custom domains (i.e. for docs.memberplatform.org). He advised me to create a feature request, which I shall.
MemberPlatform.org uses Cloudflare so I'm going to see whether I can simply proxy the subdomain from there.
Leaving this open and assigned to me until I have resolution on that.
Thank you for getting this set up!!
- πΊπΈUnited States rocketeerbkw Austin, Tx
jdleonard β credited rocketeerbkw β .
- πΊπΈUnited States jdleonard Austin, TX, USA
Cloudflare proxy seemingly isn't an option because of Drupal.org's Fastly-based protections. Added a simple redirect in the interim.
Marking this as fixed and if β¨ Enable custom domains for GitLab Pages Active gets fixed, I'll create a follow-up issue to take advantage of the custom domain in GitLab Pages.
Also crediting rocketeerbkw who helped debug the Cloudflare page rule attempts.
- πΊπΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
@jdleonard Do you still want this assigned to you since it is marked as fixed?
No problem if so. Just trying to figure out standards for this project.
- πΊπΈUnited States jdleonard Austin, TX, USA
@alexdmccabe My preference is for whatever the best practice is. I'm going to assume from the question that it is to unassign when fixed. Please educate me!
- πΊπΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
That's what core does, but my understanding is that contrib modules can do whatever they want with it, there isn't a prescribed way. So it's up to you, really. Whatever works.
- πΊπΈUnited States jdleonard Austin, TX, USA
Happy to follow core, thanks!
Fixed a stray character that caused the GitLab link in the footer to not work.