πŸ‡ΊπŸ‡ΈUnited States @alexdmccabe

Orlando, FL, US / Seminole lands
Account created on 8 June 2011, almost 14 years ago
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

What about this?

https://git.drupalcode.org/project/member/-/merge_requests/7

It has the "View exposed artifact" button on the merge request.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

I'd like to add that having working with CI/CD Components at my job they're so much better than the older template styles. The ~latest tag alone makes it worth it (it uses latest tag instead of having to use a branch). Having specific inputs and validation of those inputs (via spec:input:options, basically an enum) is also really nice to have.

I've got a pretty good amount of experience with Components now (a little more than a dozen separate projects), so if there's anything I can to do help with moving this forward, please let me know!

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

It looks like environments won't work - they seem to be blocked on the Drupal GitLab instance. For example, the environments overview page for the forked repository 404s. Linking directly to the environment (shown at the top of the preview-pages job) 404s, too.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

I might have figured that out with the environment key in the GitLab CI/CD YAML.

I'll open a follow-up issue.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

Conflict fixed. Ready for re-review.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

alexdmccabe β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

alexdmccabe β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

This is ready for review.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

alexdmccabe β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

alexdmccabe β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

That's what core does, but my understanding is that contrib modules can do whatever they want with it, there isn't a prescribed way. So it's up to you, really. Whatever works.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

@jdleonard Do you still want this assigned to you since it is marked as fixed?

No problem if so. Just trying to figure out standards for this project.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

alexdmccabe β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

alexdmccabe β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

alexdmccabe β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

alexdmccabe β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

alexdmccabe β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

alexdmccabe β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

Sorry. I must have grabbed the wrong license. Good catch.

It lives: https://project.pages.drupalcode.org/member/

Should I mark this as fixed?

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

This is ready for review.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

I'll take this on.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

I created a document in the Google Drive folder. I'll add the link to the issue description, but it's also here: https://docs.google.com/document/d/1UJ9S6V6mS_82UG64VE6EcQAMoEMO90Cys7gB...

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

That's maybe not the best experience since support for the Accept header was removed and replaced with the _format query parameter. It should probably mirror _format back instead of an otherwise unused header, shouldn't it?

As for what header I'm sending, I don't know, I opened this issue a while ago. I'll try to dig up the original circumstances.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands
πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

Thanks!

I would leave the issue at RTBC though, so the auto-update bot will continue to post patches if needed.

πŸ‡ΊπŸ‡ΈUnited States alexdmccabe Orlando, FL, US / Seminole lands

The composer.json file was missing, this patches adds it.

Production build 0.71.5 2024