Link HTTP config requests to their provider modules

Created on 22 January 2023, almost 2 years ago
Updated 27 January 2023, almost 2 years ago

Problem/Motivation

Currently the config entities that represent HTTP config requests are only linked to their respective service api. It would be nice if the were also linked to the module that implements the service api.

Proposed resolution

Add a config dependency on the module that implements the service api. This has the additional benefit of ensuring the module is installed before importing and automatically deleting the config if the module is uninstalled.

Feature request
Status

Fixed

Version

9.3

Component

Code

Created by

🇺🇸United States rocketeerbkw Austin, Tx

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @rocketeerbkw
  • @rocketeerbkw opened merge request.
  • Status changed to Needs review almost 2 years ago
  • 🇺🇸United States rocketeerbkw Austin, Tx

    I added a calculateDependencies() function to the config request entity. This adds a module config dependency every time a new one is created or updated.

    I briefly explored creating a hook_update_n to make this change for all existing HTTP config requests, but I wasn't sure what the best practice is for config entities. I think the typical workflow of importing config in production, then running database updates wouldn't be compatible with this. It would be nice to update existing config entites, and if you know what the correct method of doing it would be, I'll make it happen. But otherwise, I'll say it's a nice to have and not required.

  • Status changed to Fixed almost 2 years ago
  • 🇮🇹Italy aronne

    Hi and thank you again for your contribution @rocketeerbkw.
    Patch applied :)

    Regards,
    aronne

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024