🇨🇦Canada @jmdeleon

Released version 1.0.23 to address findings from this specific issue, particularly TSV (tab-separated values) file support.

I think the support for tab as a delimiter in configuration is a sound fix and should be included in a proper release. It is supported by PHP fgetcsv() which this module essentially serves as a wrapper for.

Please try the \t for tab in the Field formatter configuration and try a full TSV (tab-separated value) file.

Here is a patch that accepts \t in the field formatter configuration as a tab-character delimiter for tab-delimited files.

Thanks for the sample @euliss !

The simple Markdown link support within the module handled the link in the sample.

I also noticed that the sample file is tab-separated. Setting the field separator to '\t' DOES cause an error, as it tries to use the string sequence as a separator but fails.

I can put work in to better support the '\t' as an escape sequence, but as a workaround for you to get going, is it possible to use another separator character?

Uploading text files with potentially un-checked HTML introduces a security risk, and really isn't going to be supported by this module.

There is limited special support for hyperlinking when you turn on Smart URL handling (and read the module source code).

I have a small test environment set up for this, and I believe the standard file system paths have not regressed with this change.

@thhafner can you test this out and report your results here?

Proposed an alternative to @thhafner's change and merged into 1.0,x.

Merge request accepted. Basic sanity test passed. Leaving open for review.

@thhafner Awesome! Thanks for the patch. Closing.

Reviewed the code and the change seems fair. Tested a trivial non-S3FS example.

@thafner I'm going to need an explanation of why the module is incompatible with S3FS before I make a blanket statement in the documentation that the module is incompatible with S3FS.

Essentially, I'd like to address your long-term resolution, right away.

Can you reproduce the steps as to what makes this module incompatible with S3FS? Otherwise I am closing this issue.

Can you document how this incompatibility manifests itself? This may point the way to possible workarounds or at least shed some light on how the incompatibility might be resolved?

This module depends on the Drupal File Field, so any incompatibilities might be traced to incompatibilities between File Field and S3FS.

jmdeleon → created an issue.

Fixed in release 1.0.19.

This would seem to be an issue with how the DataTables library styles its elements, and doesn't really have anything to do with this Drupal module. It would be better to look at resources addressing the DataTables library directly.

@SirClickalot: "I think my suggestion to allow classes on the link itself via the UI is still a sound one."

Respectfully, I don't agree. The focus on the custom theming support in this module is on the tables, and the availability of the download link is more of a convenience, and so any theming support is deferred to the functionality offered by the File entity.

The download link produced by this module is a file_link element that should be themable with the following template, and have theme pre-process functions available to it:

https://api.drupal.org/api/drupal/core%21modules%21file%21templates%21fi...

Was getting this same error. Patch in #2 fixes it.

Can confirm commit posted resolves the issue. Hoping for a fixed release soon!

jmdeleon → made their first commit to this issue’s fork.

Submitting proposed patch.

jmdeleon → created an issue.

Re-rolling originally submitted patch, relative to WxT.

jmdeleon → created an issue.