- Issue created by @jmdeleon
- 🇨🇦Canada smulvih2 Canada 🍁
Good catch @jmdeleon! I just saw this error in one of my projects, will apply your patch to see if it resolves the issue.
- 🇨🇦Canada smulvih2 Canada 🍁
@jmdeleon, your patch is relative to the root of your project, not WxT. You should recreate your patch to remove the /html/profiles/wxt from the referenced file so the patch will apply properly. Thanks!
- Status changed to Needs work
over 1 year ago 3:03pm 30 January 2023 - 🇨🇦Canada smulvih2 Canada 🍁
I am getting a different error on the 404 page actually:
Deprecated function: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in Drupal\webform\WebformSubmissionForm->isSharePage() (line 3110 of /var/www/html/modules/contrib/webform/src/WebformSubmissionForm.php).
- 🇨🇦Canada joseph.olstad
@smulvih2 , that's a PHP 8.1 compatibility error, upgrading to the latest webform 6.1.4 should fix that.
- 🇨🇦Canada smulvih2 Canada 🍁
@joseph just upgraded to drupal/webform 6.1.4 and that fixed the error I was seeing, thanks! I am no longer seeing any errors on the 404 page.
- Status changed to Needs review
over 1 year ago 6:52pm 2 February 2023 - Status changed to Fixed
over 1 year ago 5:18pm 4 February 2023 - 🇨🇦Canada sylus
This change makes sense to me :D
Thanks everyone @jmdeleon for your time!
-
sylus →
committed 188b0b22 on 4.4.x authored by
jmdeleon →
Issue #3337399 by jmdeleon: wxt_core: 404 error pages not rendering
-
sylus →
committed 188b0b22 on 4.4.x authored by
jmdeleon →
Automatically closed - issue fixed for 2 weeks with no activity.