- Issue created by @thhafner
- 🇨🇦Canada jmdeleon
Can you document how this incompatibility manifests itself? This may point the way to possible workarounds or at least shed some light on how the incompatibility might be resolved?
This module depends on the Drupal File Field, so any incompatibilities might be traced to incompatibilities between File Field and S3FS.
- Status changed to Postponed: needs info
7 months ago 3:58am 14 June 2024 - 🇨🇦Canada jmdeleon
@thafner I'm going to need an explanation of why the module is incompatible with S3FS before I make a blanket statement in the documentation that the module is incompatible with S3FS.
Essentially, I'd like to address your long-term resolution, right away.
Can you reproduce the steps as to what makes this module incompatible with S3FS? Otherwise I am closing this issue.
- Merge request !153454516: Replace FileSystem injection with FileSystemInterface to allow for decorators. → (Merged) created by thhafner
- Status changed to Fixed
7 months ago 5:33pm 18 June 2024 - Status changed to Needs review
7 months ago 5:34pm 18 June 2024 - Status changed to RTBC
7 months ago 5:56pm 18 June 2024 - 🇨🇦Canada jmdeleon
Reviewed the code and the change seems fair. Tested a trivial non-S3FS example.
- 🇺🇸United States thhafner Chicago, IL
For completeness, this issue describes the problem and solution very well.
https://www.drupal.org/project/s3fs/issues/3352993#comment-15002764 💬 Is it expected that s3fs will override Drupal\Core\File\FileSystem service? Fixed
- Status changed to Fixed
7 months ago 6:07pm 18 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.