- Issue created by @thhafner
- π¨π¦Canada jmdeleon
Merge request accepted. Basic sanity test passed. Leaving open for review.
- Status changed to Needs review
7 months ago 9:36pm 18 June 2024 - π¨π¦Canada jmdeleon
Proposed an alternative to @thhafner's change and merged into 1.0,x.
- π¨π¦Canada jmdeleon
@thhafner can you test this out and report your results here?
- πΊπΈUnited States thhafner Chicago, IL
@jmdeleon need to use a ternary operator instead of null coalescing as realpath returns a string or FALSE not NULL when it cannot find the file.
https://www.php.net/manual/en/function.realpath.php#refsect1-function.re...
- πΊπΈUnited States thhafner Chicago, IL
I tested with the ternary operator and it works as expected with s3fs. I have not validated it with a standard public filepath yet.
-
jmdeleon β
committed 1524fbfc on 1.0.x authored by
thhafner β
Resolve #3455540 "S3fs compatability fixes"
-
jmdeleon β
committed 1524fbfc on 1.0.x authored by
thhafner β
- π¨π¦Canada jmdeleon
I have a small test environment set up for this, and I believe the standard file system paths have not regressed with this change.
- Status changed to RTBC
7 months ago 12:21am 21 June 2024 - Status changed to Fixed
7 months ago 2:08am 22 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.