๐Ÿ‡ธ๐Ÿ‡ฎSlovenia @agile-mark-l

Account created on 9 May 2022, over 2 years ago
#

Merge Requests

Recent comments

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

Since the mentioned issue was merged I am changing the status to "Needs review".

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

I have prepared the configuration update that will be needed if the solution here https://www.drupal.org/project/addtocal_augment/issues/3464990#comment-1... โœจ Provide option to omit timezone from output if UTC Active gets accepted.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

agile-mark-l โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

I added an ignore_timezone_if_UTC option to omit the timezone if it's set to UTC, aligning with the issue's proposal. The option is enabled by default and integrated into the timezone extraction and formatting logic.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

I have reviewed and tested the MR and it does fix the problem.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

I have submitted a commit that removes an unnecessary newline in the ContextManager.php file.
Additionally, I have written basic kernel tests to validate the new functionality implemented in this issue.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

agile-mark-l โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

I have checked the merge request !39 and everything discussed seems to be accounted for.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

I was not able to reproduce this issue on the 5.x branch when using field_group module version 3.6.0 and Drupal version 9.5.11.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

The patch works as described. However, please note that its effect will only apply to blocks placed after the patch is implemented. Blocks that were placed prior to the patch will remain unaffected.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

I have implemented the functionality to add coupons as a new URL parameter. The logic checks each coupon string individually to determine whether it is a coupon code or a coupon ID, then applies it to the cart accordingly.

I have not yet written tests for this new functionality. Your contributions would be appreciated if anyone is available to take on that task.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

I have replaced the custom code with SelectStoreTrait and it works okay.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

agile-mark-l โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

I have implemented the proposed resolution.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

I believe this was covered in other issues, previously merged into the 2.x branch.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

agile-mark-l โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

agile-mark-l โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

I've added a unique ID to the wrapper, which seems to fix the issue.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

agile-mark-l โ†’ changed the visibility of the branch 3427087-adding-multiple-widgets to hidden.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

MR !7 has incorporated the suggested modifications and is now awaiting review.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

I successfully addressed a merge request and implemented modifications to the classes within the 'js/entity_browser.tabs.next-gen.js' file. The adjustments to the classes now ensure that when the window width is reduced and the tabs collapse, all tabs remain visible instead of only displaying the active one.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

agile-mark-l โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

agile-mark-l โ†’ created an issue.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

I've added the mentioned update hook and also default configuration yml.

๐Ÿ‡ธ๐Ÿ‡ฎSlovenia agile-mark-l

agile-mark-l โ†’ made their first commit to this issueโ€™s fork.

Production build 0.71.5 2024