- First commit to issue fork.
- Status changed to Needs work
7 months ago 2:32pm 3 September 2024 - 🇸🇮Slovenia agile-mark-l
I have implemented the functionality to add coupons as a new URL parameter. The logic checks each coupon string individually to determine whether it is a coupon code or a coupon ID, then applies it to the cart accordingly.
I have not yet written tests for this new functionality. Your contributions would be appreciated if anyone is available to take on that task.
- 🇵🇱Poland dlevchik Poznan, Poland
dlevchik → changed the visibility of the branch 3222915-ability-to-pass to hidden.
- 🇵🇱Poland dlevchik Poznan, Poland
dlevchik → changed the visibility of the branch 3222915-ability-to-pass to active.
- 🇵🇱Poland dlevchik Poznan, Poland
Tested locally, fixed some coupons apply errors, like checking if coupon already applied, and checking promotion conditions. Added functional tests for this
Note: I think that this is strange that products in a URL use array syntax, while coupons use separating with ','. Maybe owned should look into it
- 🇬🇧United Kingdom chrisscrumping
Re the syntax if you apply my patch here: https://git.drupalcode.org/project/direct_checkout_by_url/-/merge_reques... you can use commas
See: https://www.drupal.org/project/direct_checkout_by_url/issues/3436719#com... 🐛 Can't add more than one item to cart when using comma list and reset cart Needs review