Add option to have default setting for providing menu link

There was an error with the functionality, so fixed that error and added tests.

The current MR was created against 9.5x and I don't have permission to edit the MR , so created patch

This seems close but I don't see where we are testing that the menu link is pre-checked on the node add page.

Also will need a change record with appropriate screenshots.

Hi, I updated the tests, I hope this will be enough

Change record - https://www.drupal.org/node/3373587 →

The last submitted patch, 8: 3371646-8-tests-only.patch, failed testing. View results →

Think this is better

+++ b/core/modules/menu_ui/config/schema/menu_ui.schema.yml
@@ -21,3 +21,6 @@ node.type.*.third_party.menu_ui:
+    link_by_default:

Given the schema change, wouldn't this need an upgrade path?

Closed ✨ Add a menu item for each "Basic page" by default (Standard install profile) Closed: duplicate as a duplicate

Excellent idea, lets do this. Two questions:

- Provide or create? Maybe create is the simpler word? Lets also add 'a': Create a new menu item by default.
- Was this deliberately put at the bottom of this list of settings? I can also imagine it at the top, as the very first consideration and decision to make for this menu settings section.

- Provide or create?

"Provide" is the word used in the Menu settings on the node edit form, so it might be best to keep the words consistent.

"Provide a menu link by default."
-OR-
"Provide a menu link by default when saving new content."
-OR-
"Provide a menu link by default when saving new content of this type."

The word "Add" would also make sense as it is used throughout the UI, but between the 3 proposed options (Provide, Create, Add) I'd personally vote for consistency and stick with "Provide", unless we want to change the word "Provide" to something else on the node edit form.

Note: whichever sentence ends up being used needs a . (period) at the end of the sentence.

The MR looks good overall but I think the testing could be easily extended to check if the link was actually created at admin/structure/menu/manage/main

Seems additional test coverage has been added in commit https://git.drupalcode.org/project/drupal/-/merge_requests/4642/diffs?co...

See the comment on the MR - we need to rewrite the post update.

Hiding all the files to make this easier to review.

alexpott → changed the visibility of the branch 3371646-add-option-to to hidden.