Fix modal tabs markup

Created on 5 January 2021, almost 4 years ago
Updated 15 January 2024, 10 months ago

Problem/Motivation

The tabs shown in the entity_browser overlay are hand-crafted in entity_browser.tabs.js.
Unfortunately the markup created is not compatible with current claro / gin themes.

Proposed resolution

Add additional classes to align eb tabs to current tabs markup.

🐛 Bug report
Status

Needs work

Version

2.0

Component

Display plugins

Created by

🇩🇪Germany volkerk

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • 🇸🇮Slovenia agile-mark-l

    I successfully addressed a merge request and implemented modifications to the classes within the 'js/entity_browser.tabs.next-gen.js' file. The adjustments to the classes now ensure that when the window width is reduced and the tabs collapse, all tabs remain visible instead of only displaying the active one.

  • 🇬🇧United Kingdom rick bergmann

    The patch works for me (using Claro), but the role="navigation" on the <ul> element is not a permitted aria role and fails an accessibility test.

    I found it in this line of code:

    return $('<ul class="tabs tabs--secondary" role="navigation" aria-label="Tabs"></ul>');

    See here for permitted aria roles on a <ul> element.

    Why does it have role="navigation"? Should it be removed or changed to instead of role="tablist" instead?

Production build 0.71.5 2024