Is it possible to get this merged?
Tested it with a Drupal 10 installation. The overview still breaks. Updating the status back to "Needs work".
I tested the functionality, and it works as expected! Updating the status.
As for the comment above, I think we should consider a new ticket. Because currently we have a bug, and the suggestion sounds more like a feature.
If we want to fix the way the dependency is loaded in this ticket, feel free to set the status back to "Needs work".
Created merge request and patch. This is ready to be reviewed.
There is a workaround at the moment. Manually enabling the "js_cookie" contrib module.
ahmetburkan → changed the visibility of the branch 3414301-fatal-error-when to hidden.
ahmetburkan → changed the visibility of the branch 3414301-fatal-error-when to hidden.
Update status.
After some detective work and debugging i think that we need to think about how we approach this issue. See 3383986 →
Current situation:
There is a workaround patch at comment
#5
🐛
Fatal error when adding a field to any entity type (e.g., basic page node) with GDPR module enabled on Drupal 10.2.1
Needs review
. This will disable the functionality to be able to configure GDPR fields while creating the new field. After saving the field editing the GDPR settings is possible. This requires an extra step for now.
Future:
We need to make a discission how we continue because it is not possible anymore to load the newly created field because it hasn't been saved until the last step in the field creation flow. That makes the function getFieldDefinitions() obsolete when calling it from the 'gdpr_fields.module' but not when you go directly to the route after saving the new field.
Tested the functionality and it works as expected! There is an error notification when the decrypting fails and when encrypting secure field data fails.
I agree with
eelkeblok →
about the testing part. For the sake of getting this in the codebase i will set the status to RTBC.
Looks good! Can we merge this?
It works here too. Can we merge this?
I agree with jaapjan → . It works as expected.
Tested the changes and it works as expected. This is ready to be merged!
I've tested it and it works as expected. This is ready to be merged!
Works here as well. Is it possible to create a Drupal 10 compatible release?
I agree with dennis_meuwissen → . This is a must with all the options that we have.
In my case the problem was related to 3222107 🐛 Library order asset weights do not work properly when a large number of javascript files is loaded between two jQuery UI libraries Fixed .
Reviewed and tested the changes. The module is Drupal 10 compatible. I will change the status to "Reviewed & tested by the community".
Tested. Suggested changes look good. Changing the status to 'Reviewed & tested by the community'.
Tested with Drupal 10. Looks good.
Applied the patch manually and tested it in a Drupal 10 environment. The patch applies without any problem. The Access-Control variables in the response header were as expected after the changes i have done.
This is ready for a release in Drupal 10!