Multiple warnings after upgrading to 8.x-1.5 & 2.x with js_cookie

There is a workaround at the moment. Manually enabling the "js_cookie" contrib module.

Yup that works as a workaround, thanks

Created merge request and patch. This is ready to be reviewed.

Updated title and issue summary

Code looks good. I also upgraded this to major. I haven't functionally tested the changes yet.

I've just deployed the changes with the module enabled, but I still see these errors. One part I did not give much notice, but is really kind of weird, is that the error says that the theme js_cookie is not enabled...

Sorry for the confusion. Something went wrong, errors are resolved after enabling the module. What remains is a functional test of the update hook.

Came here to mention this. It was added in 📌 Use GitLab CI for testing Fixed without its own specific issue to explain why.

Left a comment on the MR.

Create a new PR as the other one looks to be open against the 8.x-1.x branch.

Made the alteration suggested by @ericgsmith

Hi, would it be possible to remove the js-cookie dependency entirely?
I only realized now but the lib uses a CDN (both core/js-cookie and the contrib) and goes against our current CORS policy on several projects.
Looking at the autologout JS it looks rather easy/feasible but I wanted to ask here before creating a new issue.

Thanks

I tested the functionality, and it works as expected! Updating the status.

As for the comment above, I think we should consider a new ticket. Because currently we have a bug, and the suggestion sounds more like a feature.

If we want to fix the way the dependency is loaded in this ticket, feel free to set the status back to "Needs work".

If we want to fix the way the dependency is loaded in this ticket, feel free to set the status back to "Needs work".

I think your suggestion to create a new ticket is correct - this is a bug fix for something that is already released and the MR fixes this - IMO lets not delay fixing this based on another option at this point. Sounds like a good discussion to move to a new issue

+1 for RTBC

+1 to remove the dependency, but I agree it should be a new ticket. Would be good to get this merged.

Is it possible to get this merged?

I'll merge this in to fix the immediate problem. the Contrib JS cookie was added because of its removal from core... however I'd need to look back and figure out where that code is being derived from in this module. Agree that its a separate ticket.

https://www.drupal.org/project/js_cookie/ →

Automatically closed - issue fixed for 2 weeks with no activity.