Contrib.social

Fail gracefully when decrypt/encrypt fails

Open on Drupal.org →
Created on 3 November 2023, over 1 year ago

Problem/Motivation

When there is something wrong with the encryption setup, the decrypt module will throw an exception, which is never caught, resulting in the dreaded "An unexpected error occurred."

Steps to reproduce

  1. Set up a site with a content type with one or more encrypted fields
  2. Save content
  3. Break the encryption/decryption, e.g. by removing the key
  4. Try to load the content, e.g. by viewing it

Proposed resolution

Decryption: Return an empty value, show a message to the end user that decrypting encrypted data failed and write a message to the log with a little more details (e.g. what we have available, I think mostly the entity type).
Encryption: Abort saving the data (if we can, otherwise save empty data), show a message to the end user that encrypting sensitive data failed, and it was not saved, and write a log message with more details.

Remaining tasks

Reach concencus about best approach
Create an MR
Review
Merge

User interface changes

The module will now report failure in case of a problem with encryption/decryption.

API changes

None.

Data model changes

None.

🐛 Bug report
Status

Active

Version

3.1

Component

Code

Created by

🇳🇱Netherlands eelkeblok Netherlands 🇳🇱

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024