Update here, be sure to check you GA account settings.
Admin > Account > Account Details. Be sure that Data Processing Terms is unchecked. My website is US based and doesn't have GDPR requirements.
I'm running 2.0.4 and also getting this in Search Console.
tag is being places inside the
All I have tried this patch and am still having redirect issues. I'm try to redirect QuickTabs from there index to a readable name. For example
/cds?qt-tabs_cds=3 should redirect to /cds?qt-tabs_cds=connect
jmester13 → created an issue.
Apologies, I had a error in my patch. See the updated!
All,
I have updated this patch to be a bit more user friendly.
Tabs now have direct links to them and the tab URLs are updated for right clicking links.
Attached it a new patch that I hope helps others. Reach out if there any questions or things I can improve on.
I have re-rolled this patch for 8.x-1.7
Seems to be working for me at this time. I'll report back if that is not the case.
jmester13 → created an issue.
Emavo,
I used the patch I mentioned above and was able to build out comment types and associate permissions with them. So on my website I have 3 comments types.
Public - standard Drupal comment fields.
Staff - has custom fields for comments
Committee - has custom fields for comments
To leave a Staff / Committee comment you must have an account with that role.
I believed this is your goal, so if you want to chat shoot me a message and we can connect. I'm EST but flexible on timing.
@gisle thanks for the reply. I actually found that module and it's abandoned state and did some more research. I landed here, https://www.drupal.org/project/drupal/issues/1903138 📌 Move global comment permissions to comment-type level Needs work and applied this patch to my D10.1.2 and am happy to report it is working as expected for me. Hope this helps others if they land here.
Cheers All.
Wondering if any progress was made on this front with the pathway proposed above. I'm currently in need for comment type permissions based on a user role and am not seeing a D9/D10 module related to that functionality.
Thanks all.
@bluegeek9
Settings form sounds nice and makes sense to me. I wonder if we could 'detect' which modules are installed and which fields are therefore available for that settings page? Trying to think as dynamic as possible. So for example, if Table Field isn't installed the option isn't there or is at least disabled on our settings page.
I like the idea of getting granular with the table and allowing comments per table row, that makes a lot of sense to me.
@bluegeek9
We are using table field for something like a score card when a user is creating a piece of content. Probably more of and edge use case for most folks, but the project I'm working in has the need. It is a simple table, 5 rows, 5 columns which some rate 1-4 type of questions.
Thanks!
I have allowed some more fields based on a project that I'm currently working on.
Hope this helps!
Chances are I'll have more to add as this project grows.
Testing for #46 on 10.1.2
Patch applies successful.
Working with Comments on a Media type.
Unable to add conditional to a List (text) and have a conditional List (text) display.
Error is:
"Drupal\Component\Plugin\Exception\PluginNotFoundException: The "" entity type does not exist. in Drupal\Core\Entity\EntityTypeManager->getDefinition() (line 139 of core/lib/Drupal/Core/Entity/EntityTypeManager.php)."
Thanks for your efforts on this!
I tried this patch with moderation state and found it does not address that functionality.
Example:
Boolean is required when Moderation State is In Review.
Following for suggestions and ideas.
Alrighty so update here for anyone else who runs into this issue I hope it helps.
I did not use these patches in the end it comes down to logic.
Do not set required on the field itself. Use the conditional logic to set required!
For example
(checkbox) Yes / No
Do you like Pizza?
If Yes, Show text field
If Yes, Make text field required.
For Address fields, I'm still working on a resolution, looking like some type of custom JS.
@saurabh-2j17 I've tried your patch and the core patch and am not seeing a solution, but maybe because my setup is slightly different.
I have a required radio button.
When an option is selected, A required textbox should display.
When the option is not selected, the required textbox is hidden but does not allow the form to be submitted.
Also seeing this same behave for a checkbox which when selected should show a required address field.
Still researching and trying to find a solution but wanted to post here and follow.
Thanks!
+1
Working in D10 and would like to see this feature.
I've seen some D7 related issues for this in the closed issues. This is still and issue when working with D10 and I'm wondering if a solution is on the roadmap for this module.
I would also like to see this functionality. Thoughts on a timeline for completion and release?
Thanks all.
levmyshkin sorry for the delayed response.
So in my screen shot I have the following
Event
- Shows Upcoming Events
Tabs
- Shows Upcoming Events
- Shows Archived Events
So Upcoming Events is being show twice and I don't understand why. Archived events don't show twice so it seems it is the first tab in a nested tab that is displayed twice. If I change tabs between upcoming and archived upcoming remains display above the nested tabs. I hope the new screen shots make that clearer.
@levmyshkin Thanks for the quick update and release, very nice! I'd done some testing this morning and overall things are working well. I do think there is a potential for some more improvement
Currently the implementation does support nested tabs, YAY! THANK YOU!
But when tabs are nested I'm seeing the following
Tab 1, Tab 2, Tab 3 (Nested), Tab 4
Tab 3
- View Reference
- Nested Tabs as expected
I've attached a screenshot for reference. Please let me know if there is something I'm missing, but really appreciate your quick reply and update.
Cheers!
jmester13 → created an issue.
jmester13 → created an issue.
@c0debabe I believe you would want to update Line 21 of the composer.json file in the module, give that a try and let us know!
Issue here is just a stray comma, I've rolled that update into the patch posted here https://www.drupal.org/project/entity_display_tooltip/issues/3355705#com... 🐛 Tooltips do not display Active
All,
I have updated some things across the module so that it works as expected again. The reason it is currently broken is do to how fields are being obtained, there is a _ when we need a - for the field class name.
I have added a checkbox option for a div vs browser title tooltip display. Which would allow a developer to style the div to there needs. I added some basic styles to the module to get things presentable.
Cleaned up some console logs and added the D10 combability flag.
Due to the composer repo being out of date you'll need to apply this patch manually, feel free to reach out if you have questions.
I'm also happy to become a maintainer on the project but do think it's worth rolling this into https://www.drupal.org/project/field_description_tooltip → so that it's all one module for tooltips.
@claudiu.cristea
Thanks for the quick reply. I am already on 9.5.3.
I've ensured I don't have this patch in my composer file and have removed the composer.lock file and vendor directory.
I've actually tried removing the few core patches I had and am still getting this error.
Then I removed all my patches, vendor, composer.lock and removed the composer caches.
Still getting the error and seeing that the composer.lock that is generated contains the core patch.
Seems I have an oddity, any chance anyone else has been in this position. If not I'll try and check in with the folks at Acquia and see if it's something that is system related. But it almost seems that core is failing to patch itself or something?
Latest Composer log below.
Thanks all.
- Installing phpunit/phpunit (9.6.5): Extracting archive
- Applying patches for drupal/core
https://www.drupal.org/files/issues/2019-12-28/3082690-80.patch →
(3059955 - It is possible to overflow the number of items allowed in Media Library)
https://www.drupal.org/files/issues/2022-11-11/3222107-2.patch →
(3222107 - jQuery UI library order is incorrect when a large number of javascript files is loaded between two jQuery UI libraries)
https://git.drupalcode.org/project/drupal/-/merge_requests/2598.patch (3301692: Passing null to parameter to mb_strtolower() is deprecated with PHP 8.1)
https://git.drupalcode.org/project/drupal/-/merge_requests/3143.patch (3313342 - [PHP 8.1] Deprecated function: strpos(): Passing null to parameter #1 LayoutBuilderUiCacheContext.php on line 28)
Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/project/drupal/-/merge_requests/3143.patch
In Patches.php line 331:
Cannot apply patch 3313342 - [PHP 8.1] Deprecated function: strpos(): Passing null to parameter #1
LayoutBuilderUiCacheContext.php on line 28 (https://git.drupalcode.org/project/drupal/-/merge_req
uests/3143.patch)!
Hey All,
I've got a instance where this merge request is failing upon Composer update and I'm wondering is anyone else is running into that issue. Below is the error I'm getting from composer, running on Acquia.
https://git.drupalcode.org/project/drupal/-/merge_requests/2601.patch (3301770 - Passing null to parameter to strpos() is deprecated with PHP8.1)
Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/project/drupal/-/merge_requests/2601.patchIn PluginManager.php(274) : eval()'d code line 331:
Cannot apply patch 3301770 - Passing null to parameter to strpos() is deprecated with PHP8.1 (https://git.
drupalcode.org/project/drupal/-/merge_requests/2601.patch)! I'm just running composer install or composer update and getting this issue.
Thanks all.
I applied this patch to 9.5.x
I have tried patch #14 and am still unable to complete the database update.