- Issue created by @jmester13
- π·πΈSerbia levmyshkin Novi Sad, Serbia
Hi jmester13, thank you for your report! I didn't try to do it before. I prepared a patch to support nested tabs. I will test it more and merge it after testing.
- Status changed to Needs review
over 1 year ago 5:41am 7 June 2023 - π·πΈSerbia levmyshkin Novi Sad, Serbia
I pushed changes in 1.4.5 release.
- Status changed to Fixed
over 1 year ago 6:09am 7 June 2023 - πΊπΈUnited States jmester13
@levmyshkin Thanks for the quick update and release, very nice! I'd done some testing this morning and overall things are working well. I do think there is a potential for some more improvement
Currently the implementation does support nested tabs, YAY! THANK YOU!
But when tabs are nested I'm seeing the following
Tab 1, Tab 2, Tab 3 (Nested), Tab 4
Tab 3
- View Reference
- Nested Tabs as expectedI've attached a screenshot for reference. Please let me know if there is something I'm missing, but really appreciate your quick reply and update.
Cheers!
- π·πΈSerbia levmyshkin Novi Sad, Serbia
Hi jmester13, I don't undertand what's wrong on your screenshot? I see you added nested tabs or you added only two blocks with tabs? You need to create EBT Tabs block:
/block/add/ebt_tabsAnd then select this block in new tabs as a block:
Do you have any javascript errors on the page or nested tabs are not working for you?
- πΊπΈUnited States jmester13
levmyshkin sorry for the delayed response.
So in my screen shot I have the following
Event
- Shows Upcoming Events
Tabs
- Shows Upcoming Events
- Shows Archived EventsSo Upcoming Events is being show twice and I don't understand why. Archived events don't show twice so it seems it is the first tab in a nested tab that is displayed twice. If I change tabs between upcoming and archived upcoming remains display above the nested tabs. I hope the new screen shots make that clearer.
- π·πΈSerbia levmyshkin Novi Sad, Serbia
Hi jmester13, I think you have selected both fields for displaying Views and Block in tab. When you switched to "block" in Tab content, values for "views" Tabs content are still present. Template for tabs allow to diplay all Tab content fields together: Views, Blocks, Texts, etc.