Created on 6 June 2023, over 1 year ago
Updated 20 June 2023, over 1 year ago

Problem/Motivation

This plugin is awesome and easy to use out of the box it works as intended. I'm trying to work with tabs inside of tabs and finding that all tabs are in the parent tab list. Is is possible nest a EBT Tab block inside another EBT Tab Block?

Steps to reproduce

This is what I'm looking to accomplish.

Block 1 - Events
Block 1 Tab - Upcoming
Block 1 Tab - Archived

Block 2 - Project Information
Block 2 Tab - Information
Block 2 Tab - Block 1 Events (contains Upcoming and Archived)
Block 2 Tab - Other Information

I've tried pulling in blocks, view and pages, but all of those put the tabs all the tabs in Block2 navigation.

Proposed resolution

Allow nested tabs? Documentation to show another way to accomplish this?

Remaining tasks

Build and overcome. Happy to setup a demo of what I'm talking about.

User interface changes

As needed.

API changes

Data model changes

✨ Feature request
Status

Fixed

Version

1.4

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States jmester13

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @jmester13
  • πŸ‡·πŸ‡ΈSerbia levmyshkin Novi Sad, Serbia

    Hi jmester13, thank you for your report! I didn't try to do it before. I prepared a patch to support nested tabs. I will test it more and merge it after testing.

  • Status changed to Needs review over 1 year ago
  • πŸ‡·πŸ‡ΈSerbia levmyshkin Novi Sad, Serbia
  • πŸ‡·πŸ‡ΈSerbia levmyshkin Novi Sad, Serbia

    I pushed changes in 1.4.5 release.

  • πŸ‡·πŸ‡ΈSerbia levmyshkin Novi Sad, Serbia
  • Status changed to Fixed over 1 year ago
  • πŸ‡·πŸ‡ΈSerbia levmyshkin Novi Sad, Serbia
  • πŸ‡ΊπŸ‡ΈUnited States jmester13

    @levmyshkin Thanks for the quick update and release, very nice! I'd done some testing this morning and overall things are working well. I do think there is a potential for some more improvement

    Currently the implementation does support nested tabs, YAY! THANK YOU!

    But when tabs are nested I'm seeing the following

    Tab 1, Tab 2, Tab 3 (Nested), Tab 4

    Tab 3
    - View Reference
    - Nested Tabs as expected

    I've attached a screenshot for reference. Please let me know if there is something I'm missing, but really appreciate your quick reply and update.

    Cheers!

  • πŸ‡·πŸ‡ΈSerbia levmyshkin Novi Sad, Serbia

    Hi jmester13, I don't undertand what's wrong on your screenshot? I see you added nested tabs or you added only two blocks with tabs? You need to create EBT Tabs block:
    /block/add/ebt_tabs

    And then select this block in new tabs as a block:

    Do you have any javascript errors on the page or nested tabs are not working for you?

  • πŸ‡ΊπŸ‡ΈUnited States jmester13

    levmyshkin sorry for the delayed response.

    So in my screen shot I have the following

    Event
    - Shows Upcoming Events
    Tabs
    - Shows Upcoming Events
    - Shows Archived Events

    So Upcoming Events is being show twice and I don't understand why. Archived events don't show twice so it seems it is the first tab in a nested tab that is displayed twice. If I change tabs between upcoming and archived upcoming remains display above the nested tabs. I hope the new screen shots make that clearer.

  • πŸ‡·πŸ‡ΈSerbia levmyshkin Novi Sad, Serbia

    Hi jmester13, I think you have selected both fields for displaying Views and Block in tab. When you switched to "block" in Tab content, values for "views" Tabs content are still present. Template for tabs allow to diplay all Tab content fields together: Views, Blocks, Texts, etc.

Production build 0.71.5 2024