Vienna
Account created on 15 May 2017, over 8 years ago
#

Merge Requests

More

Recent comments

🇦🇹Austria arthur_lorenz Vienna

Nice approach! I have nothing to add!

🇦🇹Austria arthur_lorenz Vienna

Created a Draft MR that copies the Drupal CMS recipes, removes the custom listing page and updates the view to create a custom elements page for the listing.

Next step: Create menu entries for content listing.

🇦🇹Austria arthur_lorenz Vienna

Closing since we only provide maintenance fixes at this point.

🇦🇹Austria arthur_lorenz Vienna

Closing since we only provide maintenance fixes at this point.

🇦🇹Austria arthur_lorenz Vienna

As @golubovicm stated, the provided patch only supports translating the term's title. If we want to support translations properly, we'd need to do quite some work to achieve this. Since we only provide maintenance fixes for this project, I'll close this issue.

🇦🇹Austria arthur_lorenz Vienna

Cleaning up: Drupal 8 is not supported by the current version, therefore obsolete.

🇦🇹Austria arthur_lorenz Vienna

Thank you, please also link the issue in the README, then we can merge :)

🇦🇹Austria arthur_lorenz Vienna

Thanks, we are currently working on creating recipes based on Drupal CMS for our Lupus Decoupled stack. To provide a streamlined editing experience we base all our recipes on the drupal_cms_starter recipe. That's how we noticed that issue.

To reproduce it using only drupal_cms recipes:

* Fresh Drupal install
* Apply drupal_cms_starter recipe
* Apply drupal_cms_news recipe
* Apply drupal_cms_starter recipe again

It fails because the gin_messages-block's weight got altered.

🇦🇹Austria arthur_lorenz Vienna

Yes, exactly. The config is however in a drupal cms recipe. So this ticket exists to figure out how to deal with it.

🇦🇹Austria arthur_lorenz Vienna

MR looks good and generally this is working. I created a view, added a CE-Block display and added the block to the block layout. I tested that the title aswell as the number of results can be overridden ✅

However I came across a couple of UX issues during testing:

  • When no view title is set (which is the default) an empty title attribute is rendered. What about using the view's name as fallback?
  • All view formats other than Custom Elements don't show any results. Should we limit the options?
  • The Display Title option in the block configuration does not have any effect

Since those are minor issues, should we move them to follow up issues?

🇦🇹Austria arthur_lorenz Vienna

The shared cookie domain sections still mentions gitpod, please update!

🇦🇹Austria arthur_lorenz Vienna

Thank you! The demos work fine 🎉

However, I'd update the README file:

  • Move everything gitpod related to the bottom and mark it as deprecated
  • Add links to demo and blog setup on codespaces
  • Testing options should also use codespaces intead of gitpod
🇦🇹Austria arthur_lorenz Vienna

Great, thank you :)

Tested it locally -> RTBC ✅

🇦🇹Austria arthur_lorenz Vienna

Test failed, cache is not being invalidated after config changes.

To reproduce:

  • Install lupus_decoupled_site_info module
  • Go to /api/site-info -> Info is correct
  • Go to /admin/config/system/site-information and update the slogan
  • Go to /api/site-info -> Info is outdated
🇦🇹Austria arthur_lorenz Vienna

To summarize: The latest updates added a test of the login form provided at /ce-api/user/login by extracting the form build id and building the post request against /ce-api/user/login again. That's a sane way to test the provided form.

Code looks good to me and builds are green -> RTBC

🇦🇹Austria arthur_lorenz Vienna

Thx, I updated and commented the PR.

First, here are the Links to test the gitpod environments:
Base
Demo
Blog

Let's move the discussion for different project types here:
I introduced the env variable LD_PROJECT_TYPE that lets you choose between predefined sets of environment variables, for the ideal configurtion depending on the use case. Since we agreed on using this repo as project template as well as a demo, I figured this would be a clear way to differentiate the different types.

E.g. for demo purposes it makes a lot of sense to use the better styled shadcn frontend repo rather than our empty nuxt3 demo repo. All of the used variable can be overridden, so we don't lose any flexibility. It will make the transition to github code spaces also easier, since we do not have to keep various variable combinations in mind. And in case we want to streamline the installation process for local environments aswell, this will be a good starting point.

🇦🇹Austria arthur_lorenz Vienna

Hey :)

To create a podcast episode you'll need to either go to "/podcast-episode/add" or navigate via Admin UI to Podcasts > {{ Podcast }} > Episode List and click on "Add Podcast Episode". When published it will automatically be listed in your podcast feed.

The content type podcast episode page is just there to display an episode on your site. By default it's a simple node with a reference field for your podcast episode. You can adjust to the fields and form/view displays like for any node type at "/admin/structure/types/manage/podcast_episode_page"

I hope this helps

🇦🇹Austria arthur_lorenz Vienna

I had another look at this.

is that data- attribute not handed over to the frontend?

The antibot key is not part of the data-attribute, it is put in the drupalSettings object only.

I agree we should move the code current code lupus_decoupled_antibot and come up with a proper solution for FE. However, the main reason we wanted to support this was that it was part of Drupal CMS. Shortly before the release of 1.0.0 it got (temporarily?) thrown out due to a11y issues 📌 Remove Antibot module because of unaddressed accessibility issues Active

Since there is no timeplan yet to re-add it to Drupal CMS I'll postpone this ticket.

🇦🇹Austria arthur_lorenz Vienna

Great idea!

Let's have a brain storming session on how we want to implement it and what your exact requirements are!

🇦🇹Austria arthur_lorenz Vienna

Added some simple documentation. Follow up tickets will come later.

🇦🇹Austria arthur_lorenz Vienna

Thx, I removed the first condition.

🇦🇹Austria arthur_lorenz Vienna

It's imo safe to ignore those issues, see comment in MR

🇦🇹Austria arthur_lorenz Vienna

On Drupal side i think it's enough to expose the antibot key as a form attribute. The transformation of the key must be handled by the frontend.

🇦🇹Austria arthur_lorenz Vienna

It's simply the frontend that has no background color specified and is therefore transparent. Nothing to change here!

🇦🇹Austria arthur_lorenz Vienna

Thx, comments were adressed. I tested by creating a webform including 2 pages and confirmation page -> works like documented.

🇦🇹Austria arthur_lorenz Vienna

By default webform uses the confirmation type "page". However confirmation pages are not supported, resulting in a redirect to Drupal's frontend. I see multiple possible solutions:

  • Support confirmation pages
  • Disallow confirmation types except for inline confirmation
  • Set inline confirmation as a default and add a warning if changed to any non-supported type
🇦🇹Austria arthur_lorenz Vienna

Thanks, updated the deprecation message and added a test.

🇦🇹Austria arthur_lorenz Vienna

Adressed @smustgrave's comments.

🇦🇹Austria arthur_lorenz Vienna

arthur_lorenz made their first commit to this issue’s fork.

🇦🇹Austria arthur_lorenz Vienna

Also fixed CS and phpunit issues. Merged

Production build 0.71.5 2024