Add tests for lupus_decoupled_form

Test for user login form is now passing

this seems to miss some essential test - the actual login. I think we should add that.
also, this is only about user-forms atm, what is fine. Let's make one issue per test we add, to keep a better overview.

@fago we are already testing the logging in in https://git.drupalcode.org/project/lupus_decoupled/-/blob/1.x/modules/lupus_decoupled_user_form/tests/src/Functional/LupusSessionDomainFunctionalTest.php.

But since the main test prepares environment for testing the API output I did put the login form API output in the main module test. I'll move the endpoint testing to the form module.

Working on:

> this will slow down the setup for all the other test methods. Let's make a new Test class for form tests?

login test is covered already.

Moved the user form ce response test to user form module tests.

... I don't want to argue naming or structure of the (currently) single test file in user_login_form, here.

I agree that login (i.e. the POST request) is already tested in LupusSessionDomainFunctionalTest, though it's done implicitly as part of some other tests.

So I guess this covers what is needed / addresses earlier feedback.

I disagree. Yes, the existing LupusSessionDomainFunctionalTest test tests the user login, but not via our form integration. It's using the core JSON API for logins, see https://git.drupalcode.org/project/lupus_decoupled/-/blob/b637b316157b5e...

Imo the critical parts we need to cover here is submitting and reloading forms, as pointed out at https://www.drupal.org/project/lupus_decoupled/issues/3481050#mr101-note... 📌 Add tests for lupus_decoupled_form Active The requests the frontend would send to the backend can be seen here: https://github.com/drunomics/nuxtjs-drupal-ce/blob/2.x/src/runtime/serve... - it's a regular POST request with form-data towards `/ce-api/user/login`. The result has to be a valid custom elements response, e.g. a json page object for rendering the result-page or a json redirect resonse (not a http redirect).

Oh, right. I should have seen that this login method was a JSON API endpoint !== the form submission.

I had issue testing post request response body until I found rewind method:

$post->getBody()->rewind();

To summarize: The latest updates added a test of the login form provided at /ce-api/user/login by extracting the form build id and building the post request against /ce-api/user/login again. That's a sane way to test the provided form.

Code looks good to me and builds are green -> RTBC

Automatically closed - issue fixed for 2 weeks with no activity.