- Issue created by @arthur_lorenz
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 12:43pm 18 December 2023 - 🇦🇹Austria arthur_lorenz Vienna
Added a simple unit test to check if base paths are considered.
- 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
Looks good to me, just a suggestion for
['/web/ce-api', '', NULL] ['/ce-api?param=1', '', TRUE] ['/ce-api/?param=1', '', TRUE]
I don't know how that works in your list's organization -- lots of dimensions unfortunately :)
- 🇦🇹Austria arthur_lorenz Vienna
Thank you!
['/ce-api?param=1', '', TRUE]
actually failed. Fixed it and added a couple of test cases. - Status changed to RTBC
about 1 year ago 2:37pm 18 December 2023 - Status changed to Needs work
about 1 year ago 10:40am 22 December 2023 - 🇦🇹Austria fago Vienna
it's really great to have a test added here! I do think it's not correctly checking things though, plese take look.
- Status changed to Needs review
about 1 year ago 11:49am 22 December 2023 - 🇦🇹Austria arthur_lorenz Vienna
Commented and added tests for altered paths.
- Status changed to Needs work
about 1 year ago 3:07pm 31 December 2023 - 🇦🇹Austria fago Vienna
I see, makes sense.
TEst coverage improvement is great, however not fully there:
e.g. from test-data
'Frontpage param CE-API trailing slash' => ['/ce-api/?param=1', '', TRUE, '/'],
We should see this resulting into /?param=1 - thus we want to test not only the resulting path but the resulting request-URI really. Could you adust the test-case like this? Then I think this is ready to go.
- Status changed to Needs review
about 1 year ago 1:27pm 4 January 2024 - 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
1 commit added (and force-pushed with PHPCS fix): added "?param=1" to all expected/tested values, where the input values had them. Nothing else.
I hope this is good to merge now, per the previous comment. It simplifies other issues that need to add phpunit tests.
-
fago →
committed c5e1dd21 on 1.x authored by
arthur_lorenz →
Issue #3409409 by arthur_lorenz, roderik, fago: Respect installations...
-
fago →
committed c5e1dd21 on 1.x authored by
arthur_lorenz →
- Status changed to Fixed
about 1 year ago 11:47am 9 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.