I will work on adding a simple progress bar with clear details on stages.
The related issue, #3103090 ensures that scaffolding runs only when the current on disk file is different from what would be written.
So, this issue's scope is to ensure that scaffolding is only triggered when the scaffolding package has any update in the first place. So, that only when the scaffolding package has an update, will (as per #3103090), the on disk file will be compared.
I will work on this.
Merged MR. Thank you @nishant, @shiv_sharma, @elber.
shashikanth171 → made their first commit to this issue’s fork.
@Rajan-kumar please ensure the issue summary provides enough details when you create an issue.
Thank you @kpoornima @shiv_sharma @nishant
Thank you @omkar_yewale and @akshay_kashyap for working on this, but first we will start with the module working without domain module and for sites which use multiple domains and need settings for each domain, we can support that as a configuration or submodule. Please feel free to create a feature request issue for the same.
This issue will be fixed as part of https://www.drupal.org/project/stripe_integration/issues/3364387 📌 Remove Usage of domain Negotiator from StripeIntegrationSettingsForm Needs work
@akshay_kashyap the issue you mentioned is handled in #3364387
@akshay-kashyap please test module on latest dev branch and if you face any issue, check existing issues and update relevant issue OR if there is no relevant issue, create a new issue.
Thank you @nishant
@nishant, your screenshot is not relevant to this issue.
Thank you @shiv_sharma and @nishant
Completed Version 1 of the documentation. Marking the issue fixed for now.
shashikanth171 → created an issue.
shashikanth171 → created an issue.
Thank you @elber @shiv_sharma @sakthi_dev @nishant
Created release and added notes https://www.drupal.org/project/nginx_proxy_manager_connector/releases/1.... →
Merged the MR.
Thank you @Poornima and @shiv_sharma.
shashikanth171 → made their first commit to this issue’s fork.
shashikanth171 → created an issue.
Merged MR. Thank you, @kpoornima @shiv_sharma.
@shiv_sharma please add screenshots for any review work wherever it's relevant.
Merged MR. Thank you, @kpoornima @shiv_sharma @nishant.
@nishant and @shiv_sharma. Please add screenshots for any review wherever it's relevant.
shashikanth171 → made their first commit to this issue’s fork.
shashikanth171 → created an issue.
Thank you @shiv_sharma and @kpoornima. I have merged MR.
Thank you @shiv_sharma. Merged MR.
shashikanth171 → made their first commit to this issue’s fork.
shashikanth171 → created an issue.
shashikanth171 → created an issue.
This is a duplicate of and completed at issue https://www.drupal.org/project/sass_compile/issues/3359276 🐛 Leafo\ScssPhp library is not working Fixed
shashikanth171 → created an issue.
Merged MR. Marking issue, fixed.
I have reviewed the MR and requested few changes.
shashikanth171 → created an issue.
Thank you @shiv_sharma and @nishant. I have merged MR.
@smustgrave, I have changed the specified RegEx usages with regex literals. I don't understand your question. Can you elaborate, please?
Added README.md file.
Merged MR. Marking issue fixed.
Tested MR. Working as expected.
Tested the MR. Working as expected.
Merged and marking the issue fixed.
The patch is incomplete. It is just deleting README.txt file.
shashikanth171 → created an issue. See original summary → .
shashikanth171 → created an issue.
shashikanth171 → created an issue.
@shashank5563 I have created an MR with the fixes. Please review.
I am working on it.
@elber please share proposed solution before you start working on it. The idea is to have a way to test the API settings to verify is the connection to the Nginx Proxy Manager is working as expected.
We have a function to check the health status of the Nginx Proxy Manager instance. We can use it to check if we are able to make a call to the instance successfully.
Thank you, @kpoornima
Merged MR. I am marking the issue, fixed.
I am sorry, I understood the translatable property wrong. I thought it makes the label text translatable. But, it makes the value translatable. So, we can remove it for our config items. I have removed it.
Thank you @elber. I have merged the MR, and I am marking the issue as fixed.
shashikanth171 → created an issue.
@nishant Thank you for MR. I have made minor changes to descriptions in comments. Merged MR and marking the issue fixed.
@elber I have added comments to MR. Please check.
shashikanth171 → created an issue.
shashikanth171 → created an issue.
@shashank5563 Made some changes to the comments in the MR. Merged the MR and marking the issue Fixed.
@apaderno, I am changing the issue's scope to cover all Drupal coding standard related items.
@shashank5563, please go through all code comments and correct any issues you may find.
Thanks @Nishant
Merged MR. Changing status of the issue to fixed.
@kaustab_roy and @nishant, thank you for patches.
Please note that, before you start working on an issue, please add a comment, so that the issue can be assigned to you and duplicate efforts can be avoided.
Can any of you test the form as well and check if the values are getting saved and, on reopening, if they are loaded as default values?
@apaderno Are you suggesting that we can modify some functions from public to protected or private?
Changing names to public methods is disruptive. It is not anymore a matter of following the coding standards, but also not create issues for modules that are legitimately use public methods. These changes are rather to be considered in a separated issue.