Add tests to the features

Created on 1 May 2023, about 1 year ago
Updated 7 June 2023, about 1 year ago
✨ Feature request
Status

Needs review

Version

1.0

Component

Code

Created by

🇮🇳India shashikanth171

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @shashikanth171
  • 🇧🇷Brazil elber Brazil

    I'm looking it.

  • Status changed to Postponed about 1 year ago
  • 🇧🇷Brazil elber Brazil

    Hi this issue is postponed because it need to fixe that issue before ( https://www.drupal.org/node/add/project-issue/nginx_proxy_manager_connector → )

  • Status changed to Active about 1 year ago
  • 🇮🇳India shashikanth171

    @elber please share proposed solution before you start working on it. The idea is to have a way to test the API settings to verify is the connection to the Nginx Proxy Manager is working as expected.

    We have a function to check the health status of the Nginx Proxy Manager instance. We can use it to check if we are able to make a call to the instance successfully.

  • 🇧🇷Brazil elber Brazil

    Hi @shashikanth171 we cannot to create tests while this error still happenning

    There was 1 error:
    
    1) Drupal\Tests\nginx_proxy_manager_connector\Functional\NginxProxySettingsFormTest::testSettingsForm
    Drupal\Core\Config\Schema\SchemaIncompleteException: No schema for nginx_proxy_manager_connector.nginxproxysettings
    
    /app/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:87
    /app/web/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php:142
    /app/web/core/lib/Drupal/Core/Config/Config.php:229
    /app/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:399
    /app/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:152
    /app/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
    /app/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:327
    /app/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
    /app/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:474
    /app/web/core/tests/Drupal/Tests/BrowserTestBase.php:545
    /app/web/core/tests/Drupal/Tests/BrowserTestBase.php:364
    /app/web/modules/contrib/nginx_proxy_manager_connector/tests/src/Functional/NginxProxySettingsFormTest.php:39
    /app/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
    
    --
    
    There was 1 risky test:
    
    1) Drupal\Tests\nginx_proxy_manager_connector\Functional\NginxProxySettingsFormTest::testSettingsForm
    This test did not perform any assertions
    
    /app/web/core/tests/Drupal/Tests/Listeners/DrupalListener.php:127
    /app/vendor/phpunit/phpunit/src/Framework/TestResult.php:452
    /app/vendor/phpunit/phpunit/src/Util/PHP/AbstractPhpProcess.php:377
    /app/vendor/phpunit/phpunit/src/Util/PHP/AbstractPhpProcess.php:187
    /app/vendor/phpunit/phpunit/src/Framework/TestSuite.php:673
    /app/vendor/phpunit/phpunit/src/Framework/TestSuite.php:673
    /app/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:661
    /app/vendor/phpunit/phpunit/src/TextUI/Command.php:144
    /app/vendor/phpunit/phpunit/src/TextUI/Command.php:97
    
    ERRORS!
    Tests: 1, Assertions: 0, Errors: 1, Risky: 1.

    This is my code

    <?php
    
    namespace Drupal\Tests\nginx_proxy_manager_connector\Functional;
    
    use Drupal\Tests\BrowserTestBase;
    
    /**
     * Test to ensure that settings Form are working.
     */
    class NginxProxySettingsFormTest extends BrowserTestBase {
    
      /**
       * Administrative user.
       *
       * @var \Drupal\Core\Session\AccountInterface
       */
      protected $adminUser;
    
      /**
       * {@inheritDoc}
       */
      protected $defaultTheme = 'stark';
    
      /**
       * {@inheritDoc}
       */
      protected static $modules = [
        'nginx_proxy_manager_connector',
        'user',
        'field',
        'field_ui',
      ];
    
      /**
       * {@inheritdoc}
       */
      protected function setUp(): void
      {
        parent::setUp();
        $this->adminUser = $this->drupalCreateUser([], 'user', TRUE);
      }
    
      public function testSettingsForm(){
        $this->drupalLogin($this->adminUser);
        $this->drupalGet('admin/config/system/nginx-proxy-manager-connector/settings');
      }
    }

    We need to fix the schema error before.

  • @elber opened merge request.
  • Assigned to elber
  • 🇧🇷Brazil elber Brazil
  • Issue was unassigned.
  • Status changed to Needs review about 1 year ago
  • 🇧🇷Brazil elber Brazil

    Hi I added a basic test to settings form please revise.

Production build 0.69.0 2024