I have the same issue and also the generated .po files are huge due to this duplication. I also see no reason for this, so I created MR to remove the line you mentioned.
I don't have any issue at the moment but will update if I find something.
alexandru.dumitru → made their first commit to this issue’s fork.
Works perfectly if you are not using entity_clone.
Added a temporary fix to avoid using entity_clone for this case but surely there is a better way to handle this.
Related issue on entity_clone may be found here https://www.drupal.org/project/entity_clone/issues/3050027 🐛 Inline Blocks on Layout Builder Fail to Clone Correctly Needs work
alexandru.dumitru → made their first commit to this issue’s fork.
alexandru.dumitru → created an issue.
alexandru.dumitru → made their first commit to this issue’s fork.
alexandru.dumitru → created an issue.
alexandru.dumitru → created an issue.
alexandru.dumitru → created an issue.
What exactly core functionalities is it breaking? I tested it and checkbox groups look exactly the same with the input__checkbox__toggle suggestios, as css takes care of this case.
if (!isset($variables['element']['#weight']) || !is_float($variables['element']['#weight'])) {
This is the result if doing the above check. First item is integer, the second one is float.
alexandru.dumitru → created an issue.
alexandru.dumitru → created an issue.
alexandru.dumitru → created an issue.
This patch will trigger all errors, regardless if field if visible/hidden via conditional fields.
For example, apply the patch and hide a required field with conditional fields. Error will be triggered for the required field.